add action to publish on github package - #86
Merged
Conversation
Collaborator
Author
|
This is reverted in #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be issues with
jitpack.io(where we currently publish the JAS-mine-core` package), in particular related to setting the version of Java itself (e.g. jitpack/jitpack.io#4260 which has been longstanding, so jitpack seems unfortunately poorly maintained). Not having a hand on the package build is going to be long term headache. One possible option would be to use the Github repository instead where we can control the build via an action.This PR adds an action to publish the package to the maven github repository. Note that for now, it is only triggered manually, and changes the version to the current commit (this is to mimic what I'm using jitpack for in simpaths/SimPaths#479). My hope is to be able to use that action to reliably be able to run the SimPaths tests against an arbitrary development version of jasmine.
Note: because this is a manually triggered action, I cannot use it until it is merged. Since this PR is very self-contained and easily revertible if we then decide it isn't the direction to go, I'll exceptionally merge this PR right away so I can test whether the action works.