Code for I-MR-R/S chart - #508
Open
julianwuth wants to merge 14 commits into
Open
Conversation
There were some problems with the x-axis labels for the histogram of the residuals in DOE. This is fixed by: - Using jaspGraphs::jaspHistogram - Updating snapshots accordingly - Additionally, the binwidth method now carries over to the matrix plot.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Requires jasp-stats#504 to be merged
Contributor
Author
|
Requires #504 to be merged first. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
processCapabilityStudies() can error when capabilityDataType is missing (length-zero if), and .gitignore adds risky patterns for shared .github/ instruction paths.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an I‑MR‑R/s (between/within) variables chart for subgroups and extends Process Capability Studies to branch into attribute (binomial/Poisson) capability output; updates tests/snapshots/datasets and help text. Also removes a large set of AI/tooling instruction/config files and adds broad .gitignore patterns.
Changes:
- Add I‑MR‑R/s chart UI option (with within-chart type + moving range length) and document it.
- Route Process Capability Studies to a separate attribute capability pipeline; add datasets + snapshot coverage for binomial/Poisson.
- Update example-based tests to merge QML defaults with saved
.jaspoptions; remove various AI/tooling config/docs and adjust.gitignore.
File summaries
| File | Description |
|---|---|
| tests/testthat/test-example-ProcessCapabilityStudyWideFormat.R | Merge defaults into example opts |
| tests/testthat/test-example-ProcessCapabilityStudyLongFormat.R | Merge defaults into example opts |
| tests/testthat/datasets/processCapabilityStudy/poissonCapabilityMissing.csv | New Poisson missingness dataset |
| tests/testthat/datasets/processCapabilityStudy/poissonCapabilityEdgeCases.csv | New Poisson edge-case dataset |
| tests/testthat/datasets/processCapabilityStudy/poissonCapability.csv | New Poisson baseline dataset |
| tests/testthat/datasets/processCapabilityStudy/binomialCapabilityMissing.csv | New binomial missingness dataset |
| tests/testthat/datasets/processCapabilityStudy/binomialCapabilityEdgeCases.csv | New binomial edge-case dataset |
| tests/testthat/datasets/processCapabilityStudy/binomialCapability.csv | New binomial baseline dataset |
| tests/testthat/_snaps/variablesChartsSubgroups/i-mr-r-report1-subplot-1.svg | New i‑MR‑R/s snapshot |
| tests/testthat/_snaps/variablesChartsSubgroups/i-mr-r-report1-subplot-5.svg | New i‑MR‑R/s snapshot |
| tests/testthat/_snaps/variablesChartsSubgroups/i-mr-r-report1-subplot-6.svg | New i‑MR‑R/s snapshot |
| tests/testthat/_snaps/variablesChartsSubgroups/i-mr-r-report1-subplot-7.svg | New i‑MR‑R/s snapshot |
| tests/testthat/_snaps/variablesChartsSubgroups/i-mr-r-report1-subplot-8.svg | New i‑MR‑R/s snapshot |
| tests/testthat/_snaps/processCapabilityPoisson/poisson-report-subplot-1.svg | New Poisson report snapshot |
| tests/testthat/_snaps/processCapabilityPoisson/poisson-report-subplot-5.svg | New Poisson report snapshot |
| tests/testthat/_snaps/processCapabilityPoisson/poisson-report-subplot-6.svg | New Poisson report snapshot |
| tests/testthat/_snaps/processCapabilityPoisson/poisson-report-subplot-8.svg | New Poisson report snapshot |
| tests/testthat/_snaps/processCapabilityPoisson/poisson-histogram.svg | New Poisson histogram snapshot |
| tests/testthat/_snaps/processCapabilityBinomial/binomial-report-subplot-1.svg | New binomial report snapshot |
| tests/testthat/_snaps/processCapabilityBinomial/binomial-report-subplot-5.svg | New binomial report snapshot |
| tests/testthat/_snaps/processCapabilityBinomial/binomial-report-subplot-6.svg | New binomial report snapshot |
| tests/testthat/_snaps/processCapabilityBinomial/binomial-report-subplot-8.svg | New binomial report snapshot |
| R/processCapabilityStudies.R | Branch to attribute capability + deps |
| inst/qml/variablesChartsSubgroups.qml | Add I‑MR‑R/s controls |
| inst/help/variablesChartsSubgroups.md | Document new chart + limits |
| inst/help/attributesCharts.md | Cross-reference capability analysis |
| .vscode/mcp.json | Remove MCP config (deleted) |
| .mcp.json | Remove MCP config (deleted) |
| .gitignore | Add AI/tooling ignore patterns |
| .github/instructions/translation.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/testing.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/R.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-tables.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-state-management.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-plots.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-output-structure.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-module-architecture.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-dependency-management.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/jasp-containers-and-errors.instructions.md | Remove AI instructions (deleted) |
| .github/instructions/inst.qml.instructions.md | Remove AI instructions (deleted) |
| .claude/settings.local.json | Remove Claude config (deleted) |
| .claude/session_startup.R | Remove Claude helper (deleted) |
| .claude/rules/translation-instructions.md | Remove Claude rules (deleted) |
| .claude/rules/testing-instructions.md | Remove Claude rules (deleted) |
| .claude/rules/r-instructions.md | Remove Claude rules (deleted) |
| .claude/rules/qml-instructions.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-tables.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-state-management.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-plots.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-output-structure.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-module-architecture.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-dependency-management.md | Remove Claude rules (deleted) |
| .claude/rules/jasp-containers-and-errors.md | Remove Claude rules (deleted) |
| .claude/rules/git-workflow.md | Remove Claude rules (deleted) |
| .claude/README.md | Remove Claude docs (deleted) |
| .claude/mcp-server.R | Remove Claude MCP server (deleted) |
| .claude/hooks/block-test-edits.js | Remove Claude hook (deleted) |
Review details
- Files reviewed: 54/181 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+20
to
+24
| # Attribute (count) data has its own data entry, charts and statistics and shares nothing with the | ||
| # continuous pipeline below, so it branches out before any of it. Which of the two attribute | ||
| # analyses runs, binomial or Poisson, is decided there by attributeDistribution. | ||
| if (options[["capabilityDataType"]] == "attributes") | ||
| return(.qcAttributeCapability(jaspResults, dataset, options)) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 84.45% 85.26% +0.81%
==========================================
Files 18 19 +1
Lines 10515 11131 +616
==========================================
+ Hits 8880 9491 +611
- Misses 1635 1640 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.