Fix deprecated positional inbound agent arguments - #1361
Open
poweichen00 wants to merge 1 commit into
Open
Conversation
Signed-off-by: CHEN PO WEI <jerrychen99999@gmail.com>
Contributor
|
I don't see a warning emitted when Docker-based inbound agents are started on my Jenkins controller using the Docker plugin. Please describe the configuration you are using that shows a warning when Docker-based inbound agents are started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the default JNLP connector arguments to use the named
-secretand-nameoptions supported by Jenkins Remoting.This avoids the deprecation warning emitted when Docker-based inbound agents are started with positional secret and agent-name arguments.
Add a regression test that verifies the complete default argument list.
Fixes #1060
Testing
mvn -DskipTests spotless:checkmvn -Dtest=DockerComputerJNLPConnectorTest test