Restore Support for TFS 2017/2018 in Build Status - #199
Open
MartinPayne wants to merge 1 commit into
Open
MartinPayne wants to merge 1 commit into
MartinPayne wants to merge 1 commit into
Conversation
Use REST API version "3.0-preview.1" when posting commit or PR status back to TFS, because version "4.1-preview" is not supported by TFS 2017 or 2018.
jpricket
reviewed
May 29, 2018
| public TeamGitStatus addPullRequestStatus(final PullRequestMergeCommitCreatedEventArgs args, final TeamGitStatus status) throws IOException { | ||
|
|
||
| final QueryString qs = new QueryString(API_VERSION, "4.1-preview"); | ||
| final QueryString qs = new QueryString(API_VERSION, "3.0-preview.1"); |
There was a problem hiding this comment.
Can you use a released version? The APIs are on 5.0 now. It seems like 3.0 should not need the preview tag.
Author
There was a problem hiding this comment.
According to the documentation, the commit status API request is no longer in preview but the pull request status still is. However, for compatibility with TFS 2017 and 2018, "3.0-preview.1" looks to be the only supported version. Any other version gives a "404 - Not Found" HTTP response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use REST API version "3.0-preview.1" when posting commit or PR status
back to TFS, because version "4.1-preview" is not supported by TFS 2017
or 2018.
Resolves JENKINS-51579.