Skip to content

Removed the javax.xml.bind.DatatypeConverter as part of enabling Java 9 - #220

Open
AniketSK wants to merge 2 commits into
jenkinsci:masterfrom
AniketSK:master
Open

AniketSK wants to merge 2 commits into
jenkinsci:masterfrom
AniketSK:master

Conversation

@AniketSK

@AniketSK AniketSK commented Feb 4, 2019

Copy link
Copy Markdown

Since the javax.xml.bind package is removed in Java 9, it would help if
this package was removed from the code.
This was replaced with Apache Commons and not java.util.Base64 because
the encode function there requires compilation with java 8.

Since the javax.xml.bind package is removed in Java 9, it would help if
this package was removed from the code.
This was replaced with Apache Commons and not java.util.Base64 because
the encode function there requires compilation with java 8.
Since the javax.xml.bind package is removed in Java 9, it would help if
this package was removed from the code.
This was replaced with Apache Commons and not java.util.Base64 because
the encode function there requires compilation with java 8.
@batmat

batmat commented Feb 5, 2019

Copy link
Copy Markdown
Member

cc @jenkinsci/java11-support

@batmat batmat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@batmat

batmat commented Feb 5, 2019

Copy link
Copy Markdown
Member

Relates to https://issues.jenkins-ci.org/browse/JENKINS-55941 FYI @kelliejos @jpricketMSFT @kasubram

@alecharp alecharp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of the comment on the imports but LGTM

@MRamonLeon MRamonLeon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants