Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using VERSION_SPEC as a build parameter, the plugin should checkout the files as of that version. To do this QueryHistory is called on the version_spec, and the first changeset is returned.
The issue here is that if the project path references has been changed in newer changesets, the QueryHistory method, will return those as well, so the Plugin returns not the wanted changeset as defined by VERSION_SPEC, but the newest available changeset where changes where made to the path/project.
This PR proposes to simply limit the upper range of the query to the versionspec. This makes it so that when we return the top element, it will at most be the wanted changeset. If the changeset does not exist it will fail.