Skip to content

fix(cdc-acm): don't warn when serial console gadget is disabled #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilyongnoh-ux wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(cdc-acm): don't warn when serial console gadget is disabled #1524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cdc_acm_console.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ func handleCDCACMChannel(d *webrtc.DataChannel) {

var f *os.File
d.OnOpen(func() {
// When the serial console gadget is disabled (the default), /dev/ttyGS0
// does not exist. Skip quietly instead of warning on every channel open.
if config == nil || config.UsbDevices == nil || !config.UsbDevices.SerialConsole {
scopedLogger.Debug().Msg("CDC-ACM console is not enabled in USB device configuration")
d.Close()
return
}

var err error
f, err = os.OpenFile(cdcACMDevicePath, os.O_RDWR, 0)
if err != nil {
Expand Down
Loading