Repository navigation
Drop kappa from the A2Grad examples - #558
Open
shaneraphel wants to merge 1 commit into
Open
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
A2GradExp, A2GradInc and A2GradUni do not take kappa. The README examples passed it and raised TypeError (issue 468). AccSGD is the optimizer that uses kappa, and its example is unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #468. The README examples for
A2GradExp,A2GradIncandA2GradUnipasskappa=1000.0. Those three constructors do not takekappa(A2GradExptakesbeta,lipsandrho; the other two takebetaandlips), so copying the example raisesTypeError.kappabelongs toAccSGD, and that example is left as it is.Test plan
kappa.AccSGD(..., kappa=1000.0)still stores that value.