fix: override lodash to >=4.18.0 to resolve CVEs#636
Closed
Marcusg62 wants to merge 1 commit into
Closed
Conversation
Add npm overrides for lodash and lodash-es to force >=4.18.0 across all transitive dependencies. This resolves two high-severity vulnerabilities in lodash <=4.17.23: - GHSA-r5fr-rjxr-66jc (Code Injection via _.template imports) - GHSA-f23m-r3pf-42rh (Prototype Pollution via _.unset and _.omit) The vulnerable lodash versions are transitive dependencies brought in by karma (lodash) and mermaid/chevrotain (lodash-es). Upstream fixes are pending (karma-runner/karma#3931, Chevrotain/chevrotain#2184), so overrides are the practical fix for now. Closes jfcere#635
b44faed to
4729ec1
Compare
Owner
|
You've updated the |
Author
|
omg, that's embarrassing. yeah I think just doing that in their own repos is the best call. |
Author
|
This is my first time ever trying to contribute a fix to anything opensource, would love to help out when mermaid and karma fix there stuff and bump those dependencies here in (in the right place 😅) |
Owner
|
No worries, but I doubt there will be anything to change once mermaid update their dependencies unless they do a major version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overridesforlodashandlodash-esto force>=4.18.0across all transitive dependencies_.templateimports_.unsetand_.omitkarma(lodash) andmermaid/chevrotain(lodash-es) — not direct dependencies of ngx-markdownoverridesis the practical fix for nowCloses #635
Test plan
npm ls lodash/npm ls lodash-esconfirm 4.18.1 across the treenpm auditno longer reports lodash vulnerabilitiesnpm run lint)ng test)