Repository navigation
Fix S3 directory transfers and sync safety - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
S3 directory markers were treated as files during downloads, producing
object headerrors. Preserve exact S3 keys and folder markers across listing, copy, rename, deletion, search, and disk scans; sync now retains empty folders. Unicode, spaces, and percent characters remain intact.Abort sync planning on incomplete source scans and defer mirror deletions until copies finish successfully. CLI copy honors explicit destination filenames, stages downloads before replacement, aborts failed multipart uploads, and returns failures for incomplete hashes and failed deletions.
Fixes #33.
Validation
devand run Rust tests plus the S3 CLI audit on PRs. Seedocs/s3-testing.mdfor reproducible setup and limits.Wasabi itself has not been tested. Recursive and remote-to-remote CLI
cpremain unsupported; use sync for directory transfers.