Repository navigation
Add native Windows file drops and verified upload batches with dismissible results - #41
Merged
Merged
Conversation
Inventory selections before upload, verify remote sizes and directories, retain batch failures, and offer staged release publication. Cover assets regression with local FTP round trips and prevent duplicate concurrent retries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Document the generated x64 installer, SHA-256, preservation of application data, and the remaining manual Explorer validation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a close button to upload results, coordinate visibility with Transfers, and retain batch errors when hidden. Verify close and reopen interactions in Edge and the transfer store. Co-Authored-By: Codex <noreply@openai.com>
Refresh the installer checksum and embedded frontend reference after the upload results visibility fix. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Dragging files or folders from Windows Explorer into Faro did not enqueue native filesystem paths. Directory uploads also ignored some metadata and remote directory creation errors, allowing incomplete deployment trees without a reliable batch result. This is particularly painful for web deployments where
index.htmlcan upload while itsassetstree is missing.This adds native Tauri file-drop handling for mixed selections, with remote-pane and target-folder highlighting. Uploads now inventory the selection before remote changes, prepare directories before files, verify remote sizes, and verify the expected directories when the batch finishes. Batch summaries have a close button, can be reopened from Transfers without losing failures, and distinguish complete, partial, failed, and canceled outcomes.
Implementation
The application identifier, profile/settings formats, and credential services are unchanged. The existing lockfile had workspace package versions at 1.3.38; it is synchronized with the already-declared 1.3.48 versions, without adding application dependencies.
Validation
cargo check -p faro --locked: passed.npm run build: passed.Known limits / review notes
See
docs/windows-upload-reliability.mdfor the audit, coverage matrix, reproduction commands, and manual Windows checklist. No installer binary is included in this PR.Implementation assistance: OpenAI Codex.