Skip to content

Build for XCode 16.2; Discovered 2 unit tests were failing due to add… #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coachroebuck wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Build for XCode 16.2; Discovered 2 unit tests were failing due to add… #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fedb5ae
Build for XCode 16.2; Discovered 2 unit tests were failing due to add…
coachroebuck May 22, 2025
6d5aecf
The bot online discovered trailing white space. Removed them.
coachroebuck May 22, 2025
eaf29e9
My apologies for the typo on the word 'Strong' in my unit test.
coachroebuck Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MulticastDelegateDemo/DemoService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

import Foundation
import MulticastDelegateDemo

protocol DemoServiceDelegate {

Expand Down
29 changes: 25 additions & 4 deletions MulticastDelegateDemoTests/MulticastDelegateDemoTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,21 +291,42 @@ class MulticastDelegateDemoTests: XCTestCase {
XCTAssertTrue(multicastDelegate.isEmpty)
}

func testNotEmptyAfterAdd() {
func testNotEmptyAfterAddtrongReference() {

@bedranfleck bedranfleck Jun 3, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in strong

@coachroebuck coachroebuck Jun 4, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg... I'm sorry about that. I have the correction coming soon.


let multicastDelegate = MulticastDelegate<TestDelegate>()
multicastDelegate += DelegateTestClass()
let delegate1 = DelegateTestClass()
multicastDelegate += delegate1

Comment thread
coachroebuck marked this conversation as resolved.
Outdated
XCTAssertFalse(multicastDelegate.isEmpty)
}

Comment thread
coachroebuck marked this conversation as resolved.
Outdated
func testNotEmptyAfterDoubleAddStrongReferences() {

Comment thread
coachroebuck marked this conversation as resolved.
Outdated
let multicastDelegate = MulticastDelegate<TestDelegate>()
let delegate1 = DelegateTestClass()
let delegate2 = DelegateTestClass()
multicastDelegate += delegate1
multicastDelegate += delegate2

XCTAssertFalse(multicastDelegate.isEmpty)
}

func testNotEmptyAfterDoubleAdd() {
// Thank you ARC + Weak References
func testEmptyAfterAddWeakReference() {

Comment thread
coachroebuck marked this conversation as resolved.
Outdated
let multicastDelegate = MulticastDelegate<TestDelegate>()
multicastDelegate += DelegateTestClass()

Comment thread
coachroebuck marked this conversation as resolved.
Outdated
XCTAssertTrue(multicastDelegate.isEmpty)
}

Comment thread
coachroebuck marked this conversation as resolved.
Outdated
func testEmptyAfterDoubleAddWeakReferences() {

let multicastDelegate = MulticastDelegate<TestDelegate>()
multicastDelegate += DelegateTestClass()
multicastDelegate += DelegateTestClass()

XCTAssertFalse(multicastDelegate.isEmpty)
XCTAssertTrue(multicastDelegate.isEmpty)
}

func testEmptyAfterAddAndDelete() {
Expand Down