Setter for relations#432
Open
koenpunt wants to merge 6 commits into
Open
Conversation
Collaborator
Author
Collaborator
|
As mentioned in #125, it would be better if we switched to checking if the object was a Model instance. |
Collaborator
Author
|
Alright, I checked out @greut's work, and I have some notes:
@Rican7 @jpfuentes2 @al-the-x @cvanschalkwijk @tuupola what do you think? |
koenpunt
force-pushed
the
1.1-dev
branch
2 times, most recently
from
December 6, 2014 23:51
975878c to
6309d9e
Compare
koenpunt
force-pushed
the
greut-gh125-setter-for-relations
branch
from
December 9, 2014 23:23
35c2e28 to
ce7d77d
Compare
update test to match query string
Support for subclasses of the model specified. null is also a valid value to be set for relations
koenpunt
force-pushed
the
greut-gh125-setter-for-relations
branch
from
January 18, 2015 00:18
ce7d77d to
5b9acfd
Compare
koenpunt
force-pushed
the
1.1-dev
branch
2 times, most recently
from
June 3, 2017 14:18
494d55e to
352e1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@greut's work rebased.
To-do
fixes #125