add timeout for keepalive reply#442
Closed
ximiximi1 wants to merge 2 commits into
Closed
Conversation
Owner
|
Thanks this is a good change - will try get a sec to test it soon |
|
Hey, Is this going to merge anytime soon? Thanks!! |
|
@jpillora We are experiencing the same issues described here, and this PR will resolve them. Could you please review and merge the PR? |
|
Please I need this feature in a future release! 🙏 |
terminar
added a commit
to terminar/chisel
that referenced
this pull request
Sep 18, 2024
Owner
|
Thanks for working on this! A fix for the blocking keepalive ping has been implemented based on the approach in #581 (ping raced against a timeout, with a CHISEL_PING_TIMEOUT override) and will ship in the next release. Closing as superseded. |
jpillora
added a commit
that referenced
this pull request
Jul 16, 2026
- closed 11 superseded dependabot PRs (#448 #449 #450 #451 #467 #470 #478 #496 #513 #516 #517) — deps updated via #568/#578 - closed duplicate keepalive PRs #488/#442 with thanks (#581's approach won, implemented in task 1) - closed keepalive issues #445/#560 (fixed by task 1, ships next release); #585/#541 were already closed - left #504/#550/#485 for task 22 and #561/#498 for task 23, as those tasks deliver the fixes that close them - filed task 35: decide dependabot grouped updates vs renovate Closes md task 21 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sshConn.Send Request will send message and block wait the reply.
The keepalive will not work in some special condition. For example, when the server use memory snapshot to hibernate and did not close the socket normally and there is a websocket middware like Cloudflare to proxy the websocket, when the server hibernate with memory snapshot, Cloudflare will not close the websocket connection during a very long time(this maybe a issue of Cloudflare), in the mean while, the keepalive block wait the reply(there will not have a reply as server hibernated), as a result, the ssh connection will not close until the Cloudflare close the websocket(very long time above 10min).
So I add a reply timeout for the keepalive. A timeout error will raise when wait the keepalive reply too long, and then close the ssh connetion.