fix: typefix the string.ensure() method#2296
Open
vmanera wants to merge 1 commit into
Open
Conversation
deansimcox
approved these changes
Jul 21, 2025
deansimcox
left a comment
deansimcox
left a comment
There was a problem hiding this comment.
Love your work.
Happy to see the as any on line 271 has been removed.
5 ⭐ 's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
string.ensure()method applies.default(''), however this information does not flow to typescript. This happens because the explicit return type of the method causes a loss of information about the transforms that happen within. The typing changes I have in this PR will ensure the type information flows through correctly.Pragmatically, this issues effects the use of
Schema.getDefault()method. Without this fix, any strings using.ensure()will have a type ofundefined, but a runtime value of"".