Run push build only on the master branch#1550
Conversation
|
@k-okada You can see there is only a single build of Travis CI. |
|
I'm afraid this will not run travis on PRs from other repository. |
|
You're right. I will check that. BTW, do u know why it fails bacause of timeout when I create branch on the origin? |
|
I confirmed that the PR build is triggered #1551 |
|
https://travis-ci.org/jsk-ros-pkg/jsk_common/jobs/266690515
```
import pkg_resources._vendor.packaging._compat # precompiled from
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/_compat.pyc
#
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/requirements.pyc
matches
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/requirements.py
import pkg_resources._vendor.packaging.requirements # precompiled from
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/requirements.pyc
#
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/pyparsing.pyc
matches
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/pyparsing.py
import pkg_resources._vendor.pyparsing # precompiled from
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/pyparsing.pyc
# /usr/lib/python2.7/weakref.pyc matches /usr/lib/python2.7/weakref.py
import weakref # precompiled from /usr/lib/python2.7/weakref.pyc
# /usr/lib/python2.7/copy.pyc matches /usr/lib/python2.7/copy.py
import copy # precompiled from /usr/lib/python2.7/copy.pyc
# /usr/lib/python2.7/pprint.pyc matches /usr/lib/python2.7/pprint.py
import pprint # precompiled from /usr/lib/python2.7/pprint.pyc
# /usr/lib/python2.7/threading.pyc matches /usr/lib/python2.7/threading.py
import threading # precompiled from /usr/lib/python2.7/threading.pyc
#
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/markers.pyc
matches
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/markers.py
import pkg_resources._vendor.packaging.markers # precompiled from
/usr/local/lib/python2.7/dist-packages/pkg_resources/_vendor/packaging/markers.pyc
No output has been received in the last 10m0s, this potentially indicates a
stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on:
https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
```
I think this something similar to the problem reported at
https://blog.sqreen.io/freeze-python-str-encode-threads/
…--
◉ Kei Okada
2017-08-21 23:36 GMT+09:00 Kentaro Wada <notifications@github.com>:
I confirmed that the PR build is triggered #1551
<#1551>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1550 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3GQI-a-6R1OrtDJqFo88_bwE7yVqks5saZX3gaJpZM4O9AXV>
.
|
|
That's interesting. Thank you. |
Agreed, I think some of PR pushed to master banch has merged, without checking the situation where someone created PR from their forked repository, or some of pip package has been updated. I think you're expert on both cases. c.f. #1562 |
|
@wkentaro |
wkentaro
force-pushed
the
push_build_only_on_master
branch
from
403ae94 to
adb5552
Compare
|
Rebased. |
|
it seems travis running ok for recent PR's #1573 |
|
Testing push build is just a duplicate and not required, so I think it is better that we avoid that. |
|
@k-okada Could you please merge this? |
|
@k-okada ping |
|
I think we no longer need this. Not sure why, ...
|
|
@k-okada I think it is because he sends the PR from his forked repository. |
|
I prefer everyone send PR from forked repository .
…--
◉ Kei Okada
2018-01-09 23:03 GMT+09:00 Kentaro Wada <notifications@github.com>:
@k-okada <https://github.com/k-okada> I think it is because he sends the
PR from his forked repository.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1550 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3BYyJDi1RqtX3NqgsZPn-NrzDBvqks5tI3GugaJpZM4O9AXV>
.
|
So this PR is not necessary for now. |
3 participants
For #1549 (comment)
Close #1551