jsk_data: download_data.py: ensure chmod downloaded data if possible#1571
Merged
Conversation
furushchev
force-pushed
the
fix-jsk-data
branch
from
74a48fc to
b8cd8a4
Compare
wkentaro
requested changes
Nov 2, 2017
| if not is_file_writable(path): | ||
| os.chmod(path, 0777) | ||
| orig_path = osp.splitext(path)[0] + '.orig.bag' | ||
| if not is_file_writable(path): |
furushchev
force-pushed
the
fix-jsk-data
branch
from
b8cd8a4 to
7328bd7
Compare
Member
Author
|
@wkentaro Any other comments? |
wkentaro
approved these changes
Nov 6, 2017
Member
Author
Member
Author
|
@k-okada Please merge this if there is no problem, since without this pull request building |
Member
Author
|
wait for #1573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chmodsinceos.chmodfails when changing the permission of files which were already changed.