Fix $contains crash when the token is undefined#809
Open
apoorva-01 wants to merge 1 commit into
Open
Conversation
An undefined second arg fell through to the regex-matcher branch, which called .apply on it and threw. Return undefined instead, matching the existing check on str. Signed-off-by: Apoorva Verma <vermaapoorva0510@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$contains("Hello World", nothing)throws instead of returning undefined. Any time the second arg resolves to undefined it slips past the string check into the regex-matcher branch and calls.applyon undefined.containsalready returns undefined whenstris undefined, so I just extended that guard to the token too.Heads up:
$splitand$replaceshare the sameevaluateMatcherpath and blow up the same way ($matchis fine, its signature rejects undefined first). I kept this scoped to$contains. If you'd rather squash all three at once, a guard insideevaluateMatcherwould do it, but that's a wider change so I left it to you.Added a test case that goes fail -> pass with the change, full suite green at 100% coverage.
closes #584
Signed-off-by: Apoorva Verma vermaapoorva0510@gmail.com