svc: support closing via context#13
Merged
Merged
Conversation
Owner
|
@jehiah Thanks. I'll check and merge over the weekend |
Owner
|
LGTM |
Contributor
Author
|
Thanks @judwhite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nsqio/nsq#1305 I encountered a situation where I wanted to add additional hooks for exiting a process - but the only exit path for Run() is a
SIGINT/SIGTERM. In order to add new way for applications to signal that the process should exit I am adding a conditionalContextinterface that applications can implement. When implementedsvcwill wait for aSIGINT/SIGTERMOR for the context to finish.