Fix overflow for JupyterLite iframes when added by directives used inside PST admonitions#333
Open
agriyakhetarpal wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the visual bug I identified in point 1 of #290 (comment) about the JupyterLite REPL (and other apps') iframes overflowing if they are part of admonitions. This is a hack right now and may or may not work with other themes, but we've never marketed official support of the extension for themes beyond the PST anyway.
Since #290 is not merged yet, I applied these changes on top of it locally, and the following screenshots showcase the difference/fix (please ignore the non-working iframe in the "After" image, that's not related):
also cc: @Carreau for visibility; as this involves the PST