Skip to content

feat(custom-webpack)!: remove Karma builder and tests (Angular 22 removes Karma) #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
just-jeb wants to merge 1 commit into from
Closed

feat(custom-webpack)!: remove Karma builder and tests (Angular 22 removes Karma) #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ examples/
sanity-esbuild-app/ -- CJS/ESM/TS plugin variants, vitest builder
sanity-esbuild-app-esm/ -- Same tests in an ESM-type package
custom-webpack/
sanity-app/ -- Basic browser + dev-server + karma tests
sanity-app/ -- Basic browser + dev-server tests
sanity-app-esm/ -- Same tests in an ESM-type package
full-cycle-app/ -- Full webpack customization + indexTransform tests
jest/
Expand Down
4 changes: 0 additions & 4 deletions examples/custom-webpack/full-cycle-app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ Run `ng generate component component-name` to generate a new component. You can

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory. Use the `--prod` flag for a production build.

## Running unit tests

Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).

## Running end-to-end tests

Run `ng e2e` to execute the end-to-end tests via [Protractor](http://www.protractortest.org/).
Expand Down
20 changes: 0 additions & 20 deletions examples/custom-webpack/full-cycle-app/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,26 +107,6 @@
"buildTarget": "full-cycle-app:build"
}
},
"test": {
"builder": "@angular-builders/custom-webpack:karma",
"options": {
"polyfills": [
"zone.js",
"zone.js/testing"
],
"tsConfig": "tsconfig.spec.json",
"inlineStyleLanguage": "scss",
"karmaConfig": "karma.conf.js",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.scss"
],
"scripts": []
}
},
"e2e": {
"builder": "@cypress/schematic:cypress",
"options": {
Expand Down
60 changes: 0 additions & 60 deletions examples/custom-webpack/full-cycle-app/karma.conf.js
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions examples/custom-webpack/full-cycle-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"scripts": {
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e",
"cypress:open": "cypress open",
Expand Down Expand Up @@ -32,19 +31,11 @@
"@angular/compiler-cli": "21.2.15",
"@angular/language-service": "21.2.15",
"@eslint/js": "10.0.1",
"@types/jasmine": "6.0.0",
"@types/node": "24.12.4",
"angular-eslint": "21.4.0",
"cypress": "15.16.0",
"eslint": "10.4.1",
"html-webpack-plugin": "5.6.7",
"jasmine-core": "6.2.0",
"karma": "6.4.4",
"karma-chrome-launcher": "3.2.0",
"karma-coverage": "2.2.1",
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.2.0",
"puppeteer": "24.43.1",
"ts-node": "10.9.2",
"typescript": "5.9.3",
"typescript-eslint": "8.60.0"
Expand Down
4 changes: 0 additions & 4 deletions examples/custom-webpack/sanity-app-esm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ Run `ng generate component component-name` to generate a new component. You can

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory.

## Running unit tests

Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).

## Running end-to-end tests

Run `ng e2e` to execute the end-to-end tests via a platform of your choice. To use this command, you need to first add a package that implements end-to-end testing capabilities.
Expand Down
20 changes: 0 additions & 20 deletions examples/custom-webpack/sanity-app-esm/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,26 +118,6 @@
"buildTarget": "sanity-app-esm:build"
}
},
"test": {
"builder": "@angular-builders/custom-webpack:karma",
"options": {
"polyfills": [
"zone.js",
"zone.js/testing"
],
"tsConfig": "tsconfig.spec.json",
"inlineStyleLanguage": "scss",
"karmaConfig": "karma.conf.cjs",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.css"
],
"scripts": []
}
},
"cypress-run": {
"builder": "@cypress/schematic:cypress",
"options": {
Expand Down
56 changes: 0 additions & 56 deletions examples/custom-webpack/sanity-app-esm/karma.conf.cjs
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions examples/custom-webpack/sanity-app-esm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"build": "ng build",
"build-ts": "TS_NODE_PROJECT=tsconfig.app.json NODE_OPTIONS='--loader ts-node/esm' ng build",
"watch": "ng build --watch --configuration development",
"test": "ng test",
"e2e": "ng e2e",
"cypress:open": "cypress open",
"cypress:run": "cypress run"
Expand All @@ -34,16 +33,8 @@
"@angular/cli": "21.2.13",
"@angular/compiler-cli": "21.2.15",
"@cypress/schematic": "5.0.0",
"@types/jasmine": "6.0.0",
"@types/node": "24.12.4",
"cypress": "15.16.0",
"jasmine-core": "6.2.0",
"karma": "6.4.4",
"karma-chrome-launcher": "3.2.0",
"karma-coverage": "2.2.1",
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.2.0",
"puppeteer": "24.43.1",
"typescript": "5.9.3"
}
}
4 changes: 0 additions & 4 deletions examples/custom-webpack/sanity-app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ Run `ng generate component component-name` to generate a new component. You can

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory. Use the `--prod` flag for a production build.

## Running unit tests

Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).

## Running end-to-end tests

Run `ng e2e` to execute the end-to-end tests via [Protractor](http://www.protractortest.org/).
Expand Down
20 changes: 0 additions & 20 deletions examples/custom-webpack/sanity-app/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,6 @@
"buildTarget": "sanity-app:build"
}
},
"test": {
"builder": "@angular-builders/custom-webpack:karma",
"options": {
"polyfills": [
"zone.js",
"zone.js/testing"
],
"tsConfig": "tsconfig.spec.json",
"inlineStyleLanguage": "scss",
"karmaConfig": "karma.conf.js",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.scss"
],
"scripts": []
}
},
"e2e": {
"builder": "@cypress/schematic:cypress",
"options": {
Expand Down
60 changes: 0 additions & 60 deletions examples/custom-webpack/sanity-app/karma.conf.js
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions examples/custom-webpack/sanity-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"scripts": {
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e",
"cypress:open": "cypress open",
Expand Down Expand Up @@ -32,18 +31,10 @@
"@angular/compiler-cli": "21.2.15",
"@angular/language-service": "21.2.15",
"@eslint/js": "10.0.1",
"@types/jasmine": "6.0.0",
"@types/node": "24.12.4",
"angular-eslint": "21.4.0",
"cypress": "15.16.0",
"eslint": "10.4.1",
"jasmine-core": "6.2.0",
"karma": "6.4.4",
"karma-chrome-launcher": "3.2.0",
"karma-coverage": "2.2.1",
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.2.0",
"puppeteer": "24.43.1",
"ts-node": "10.9.2",
"typescript": "5.9.3",
"typescript-eslint": "8.60.0"
Expand Down
1 change: 0 additions & 1 deletion packages/custom-webpack/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ package
dist
**/schema.json
*.js
!karma.conf.js
!*webpack.config.js
!*index-html.transform.js
*.js.map
Loading
Loading