Use the verifier that recognizes Homebrew's manifest downloads - #28
Merged
Merged
Conversation
Pin production, dry-run, and maintenance callers to the immutable Kandelo merge that recognizes Homebrew's exact GHCR manifest fetch. Rotate the trust history so the displaced #985 generation is rejected as previous rather than remaining accepted implicitly.
Contributor
Author
|
Candidate trust is green: https://github.com/kandelo-dev/homebrew-tap-core/actions/runs/29700717089/job/88229200961 The base-owned check failed at its intended review boundary with exactly: That is expected for this coherent caller/trust-root rotation. The candidate parser accepted the complete new generation, and the local Ruby parser, shell wrapper, syntax check, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The zlib and bzip2 pilots reached a successful anonymous Homebrew download, bottle pour, and Formula runtime test, but the old verifier rejected Homebrew's normal GitHub Container Registry (GHCR) manifest log line. Automattic/kandelo#988 fixes that false failure and merged as immutable commit
353b9f818ac46ad0c7eb7b5bbc692aaab3c1af6c.This tap still calls the older #985 workflow. Retrying the pilots before rotating the pin would therefore reproduce the same known verifier failure. The tap callers and their trust root must move together so production cannot mix workflow generations.
Automattic/kandelo#987 merged afterward as current
maincommitc69d3d2baae22efabdc8d570b158396953bd8429; it changed documentation only. Production continues to requirekandelo-ref: main, while the reusable workflow itself is purposefully pinned to the code-bearing #988 merge.What changed
Validation
ruby -c Kandelo/test-workflow-trust.rb— passed.ruby Kandelo/test-workflow-trust.rb— passed.bash Kandelo/test-workflow-trust.sh— passed.git diff --check— passed.The candidate
publisher-trustcheck must pass. The base-ownedpublisher-trust-basecheck is expected to fail because this PR intentionally changes protected caller/trust files; that failure is the review gate, not a publisher defect.Rollout
After the candidate trust check and the merged #988 staging run are green, merge this tap-only update. Then retry zlib
1.3.1_3and bzip21.0.8_2concurrently without changing their identities. Tap PR #4 remains unmerged until both pilots are accepted.