fix: correct broken links, typos, and grammar in Generic Extractor docs (PRDCT-365 audit) - #398
fix: correct broken links, typos, and grammar in Generic Extractor docs (PRDCT-365 audit)#398Iamfle4ka wants to merge 1 commit into
Conversation
Fixes PRDCT-365 - A1: Fix offset link pointing to pagenum page (pagination/index.md L121) - A2: Remove stray bracket after EX139 link (pagination/index.md L341) - A3: Fix nextFlag -> nextPageFlag config property name (pagination/index.md L123) - C1: Fix typo 'tu' -> 'to' (ssh-proxy/index.md L13) - C2: Fix sentence fragment between EX131 and EX133 links (ssh-proxy/index.md L94-95) - C3: Fix grammar 'signaturing' -> 'signing' (aws-signature/index.md L9) - C4: Fix grammar 'extractor sign' -> 'the extractor signs' (aws-signature/index.md L10) - C5: Fix broken sentence fragment in userData docs (config/index.md L163-165) - C6: Clarify mutually exclusive limitStop params (pagination/index.md L240-241) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 2/5) · profile docs
Clean, low-risk docs fixes, but a link target and two product-behaviour claims can't be verified from the diff — route to human.
Concerns:
extend/generic-extractor/configuration/api/pagination/index.md: A1 new link target .../pagination/offset/ existence unverifiable at HEADextend/generic-extractor/configuration/api/pagination/index.md: A3 param rename nextFlag→nextPageFlag is a product-behaviour claim; confirmextend/generic-extractor/configuration/api/pagination/index.md: C6 limitStop count/field requirement change needs product confirmation
Suggested reviewers: @keboola/docs
|
Superseded by #410, which carries all four files. One hunk was dropped as a duplicate — the All three of the bot's concerns are now confirmed:
Generic Extractor stays on this site (per Branch stays cherry-pickable. |
Jira issue(s): PRDCT-365
Changes:
Unambiguous fixes from the PRDCT-365 developers-docs audit of
/extend/generic-extractor/. All 3 needs_human items (A4: backoff formula, A5: retryConfig sample, A6: zendesk.response.url) are excluded — zero needs_human rows in this diff.Code-accuracy fixes (Block A):
pagination/index.md: Fix broken link —offset methodspointed to.../pagination/pagenum/instead of.../pagination/offset/pagination/index.md: Remove stray]after[EX139]markdown linkpagination/index.md: FixnextFlag→nextPageFlag(matchesHasMoreScrollerDecorator.php:39)Doc-hygiene fixes (Block C):
ssh-proxy/index.md: Typo "tu" → "to"ssh-proxy/index.md: Fix sentence fragment between EX131/EX133 linksaws-signature/index.md: "signaturing" → "signing"aws-signature/index.md: "extractor sign" → "the extractor signs"config/index.md: Merge broken sentence fragment in userData docspagination/index.md: Clarify mutually exclusivelimitStopparams (count/field)Full audit log with Block 0 (39-page classification), Block A, Block B (verified-accurate), Block C, and summary posted as comment on PRDCT-365."
Link to Devin session: https://app.devin.ai/sessions/4971d8270e1f44c79b2acf4625b5f226
Requested by: @Iamfle4ka