Repository navigation
Fix quoting completions with trailing spaces - #388
Merged
kelleyma49 merged 3 commits intoSep 20, 2026
Merged
Conversation
ReKylee
force-pushed
the
fix/completion-trailing-space
branch
from
September 19, 2026 14:57
9d5b8e9 to
995eae2
Compare
Owner
|
Merged. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some completers, including Carapace, include a trailing separator in
CompletionText. PSFzf currently passes that separator throughFixCompletionResult, which makes an otherwise simple completion look like it contains whitespace and causes it to be quoted.Strip one trailing space or tab before quoting. PSFzf already appends its own separator after processing, so this avoids quoting the separator while preserving whitespace that is part of the actual completion value.
For example,
buildnow becomesbuildinstead of"build ", whilemy filestill becomes"my file".Fixes #386