Skip to content

Fix httpx support (select between allow_redirects/follow_redirects)#621

Merged
jairhenrique merged 2 commits into
kevin1024:masterfrom
immerrr:fix-httpx-support
Apr 19, 2022
Merged

Fix httpx support (select between allow_redirects/follow_redirects)#621
jairhenrique merged 2 commits into
kevin1024:masterfrom
immerrr:fix-httpx-support

Conversation

@immerrr
Copy link
Copy Markdown
Contributor

@immerrr immerrr commented Nov 14, 2021

This PR should fix the incompatibility introduced by the recent httpx release, when allow_redirects param was replaced with follow_redirects and default was changed from True to False.

@immerrr
Copy link
Copy Markdown
Contributor Author

immerrr commented Nov 14, 2021

The CI build failed in my repo, due to what looks like a failure in pytest-httpbin:

https://github.com/immerrr/vcrpy/runs/4205197603?check_suite_focus=true#step:6:2872

I have submitted a PR to pytest-httpbin repo to fix this.

@immerrr
Copy link
Copy Markdown
Contributor Author

immerrr commented Nov 14, 2021

I have submitted a temporary commit that points pytest-httpbin dependency to a branch in my repo with the fix:

https://github.com/immerrr/vcrpy/actions/runs/1459899288

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 18, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (c3767c2) to head (bc2ce2e).
⚠️ Report is 332 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   89.85%   89.82%   -0.03%     
==========================================
  Files          27       27              
  Lines        1734     1730       -4     
  Branches      285      287       +2     
==========================================
- Hits         1558     1554       -4     
  Misses        140      140              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@jairhenrique jairhenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevin1024 can you review and bump a new version of pytest-httpbin kevin1024/pytest-httpbin#62

@jairhenrique jairhenrique merged commit f5ea030 into kevin1024:master Apr 19, 2022
@immerrr
Copy link
Copy Markdown
Contributor Author

immerrr commented Apr 19, 2022

Thank you @jairhenrique

@immerrr immerrr deleted the fix-httpx-support branch April 19, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants