Fix httpx support (select between allow_redirects/follow_redirects)#621
Conversation
|
The CI build failed in my repo, due to what looks like a failure in pytest-httpbin: https://github.com/immerrr/vcrpy/runs/4205197603?check_suite_focus=true#step:6:2872 I have submitted a PR to pytest-httpbin repo to fix this. |
d7dda48 to
1540504
Compare
|
I have submitted a temporary commit that points |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 89.85% 89.82% -0.03%
==========================================
Files 27 27
Lines 1734 1730 -4
Branches 285 287 +2
==========================================
- Hits 1558 1554 -4
Misses 140 140
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jairhenrique
left a comment
There was a problem hiding this comment.
LGTM.
@kevin1024 can you review and bump a new version of pytest-httpbin kevin1024/pytest-httpbin#62
f6976f3 to
7cc5c76
Compare
7cc5c76 to
bc2ce2e
Compare
|
Thank you @jairhenrique |
This PR should fix the incompatibility introduced by the recent
httpxrelease, whenallow_redirectsparam was replaced withfollow_redirectsand default was changed fromTruetoFalse.