Fix broken HTML report/reimplement call table - #3139
Closed
ncatlin wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
closing as this was on the wrong branch and needs fiddling with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR addresses #3088 where there was errors in HTML report generation and the behaviour section was empty.
Credit to @zOLakh for reporting it and @ppil for diagnosing it
Changes
The HTML reports do get quite big for large traces because unlike the web version we don't have the luxury of calling the chunk API and everything has to be embedded.
Output
No more report generation errors
Restored the process tree (this isn't actually the same as the more minimal web version)