-
Notifications
You must be signed in to change notification settings - Fork 72
Make compilation to fail on warnings #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarroutbi
wants to merge
6
commits into
keylime:master
Choose a base branch
from
sarroutbi:202509030938-fail-compilation-on-warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bbe92d0
Include CI GH action to avoid compilation warnings
sarroutbi 547b101
Fix no-warnings CI workflow
sarroutbi a5426da
Add git safe.directory to no-warnings CI job
sarroutbi 1f8e449
Fix extra space in clippy command in CI workflow
sarroutbi b0e5ecd
Pin CI image to digest in no-warnings workflow
sarroutbi 7963696
Fix compilation warning
sarroutbi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| name: No-Warnings Compilation | ||
|
|
||
| "on": | ||
| push: | ||
| branches: [master] | ||
| pull_request: | ||
| branches: [master] | ||
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
|
|
||
| jobs: | ||
| basic-compilation: | ||
| name: Compilation with no warnings | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| # To refresh: skopeo inspect --no-tags docker://quay.io/keylime/keylime-ci:latest | jq -r '.Digest' | ||
| image: quay.io/keylime/keylime-ci@sha256:973f36045d0dd0b1a219dd88f06625c65a77f267842ee23d955e0c095ef09ff2 | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Set git safe.directory for the working directory | ||
| run: git config --system --add safe.directory "$PWD" | ||
| - name: Check compilation (no warnings) | ||
| run: RUSTFLAGS="-D warnings" cargo build | ||
| - name: Check test compilation (no warnings) | ||
| run: RUSTFLAGS="-D warnings" cargo test --no-run | ||
| - name: Check clippy errors (no warnings included) | ||
| run: cargo clippy --all-features --all-targets -- -D clippy::all -D warnings | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.