refactoring #53
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,8 @@ labels: | |
| body: > | ||
| This issue has been marked as a good first issue for first-time contributors to implement! | ||
| This is a great way to support the project, while also improving your skills, you'll also be credited as a contributor once your PR is merged. | ||
| If you're new to web development, [here are a collection of resources](https://live-ship.vercel.app/docs/developing#resources-for-beginners) | ||
| to help you get started. You can also find step-by-step tutorials for common tasks within Shipyard, on the [Dev Guides](https://live-ship.vercel.app/docs/development-guides) page. | ||
| If you need any support at all, feel free to reach out via [GitHub Discussions](https://github.com/khulnaSoft/shipyard/discussions). | ||
|
|
||
| - name: ❌ wontfix | ||
|
|
@@ -31,14 +31,14 @@ labels: | |
| action: close | ||
| body: > | ||
| This ticked has been marked as 'wontfix', which usually means it is out-of-scope, or not feasible at this time. | ||
| You can still fork the project and make the changes yourself, for support in doing so, please reference the [Developing Docs](https://live-ship.vercel.app/docs/developing). | ||
|
|
||
| - name: ✅ Fixed | ||
| labeled: | ||
| issue: | ||
| body: > | ||
| Hello @{{ issue.user.login }}! It looks like all or part of this issue has now been implemented :) | ||
| If you're enjoying Shipyard, please consider supporting the project- for ways to get involved, see [Contributing](https://live-ship.vercel.app/docs/contributing) 💖 | ||
|
|
||
| - name: ‼️ High Priority | ||
| labeled: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ jobs: | |
| maintainer=khulnasoft | ||
| org.opencontainers.image.title=Shipyard | ||
| org.opencontainers.image.description=A self-hosted startpage for your server | ||
| org.opencontainers.image.documentation=https://live-ship.vercel.app/docs | ||
| org.opencontainers.image.authors=Md Sulaiman | ||
| org.opencontainers.image.licenses=MIT | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| live-ship.vercel.app | ||
|
Contributor
There was a problem hiding this comment. 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win ✅ Runtime observed🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n 'CNAME|github-pages|gh-pages|vercel' .github package.json README.md
curl -fsSIL --max-time 15 https://live-ship.vercel.appRepository: khulnasoft/shipyard Length of output: 2846 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- CNAME ---'
cat -n CNAME
printf '%s\n' '--- documentation deployment workflow ---'
cat -n .github/workflows/build-docs-site.yml
printf '%s\n' '--- repository deployment/configuration references ---'
rg -n -i 'vercel|github pages|github-pages|custom domain|CNAME|deployment-branch|project' \
.github README.md package.json vercel.json vercel.* 2>/dev/null || true
printf '%s\n' '--- tracked deployment-related files ---'
git ls-files | rg -i '(^|/)(CNAME|vercel(\..*)?|.*pages.*|.*deploy.*)$' || trueRepository: khulnasoft/shipyard Length of output: 4895 Do not point the GitHub Pages The docs workflow publishes to 🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| <br/> | ||
| <img width="120" src="https://i.ibb.co/yhbt6CY/shipyard.png" /> | ||
| <br/> | ||
| <b><a href="./docs/showcase.md">User Showcase</a></b> | <b><a href="https://demo.live-ship.vercel.app">Live Demo</a></b> | <b><a href="./docs/quick-start.md">Getting Started</a></b> | <b><a href="https://live-ship.vercel.app/docs">Documentation</a></b> | <b><a href="https://github.com/khulnaSoft/shipyard">GitHub</a></b> | ||
| </p> | ||
|
|
||
| <p align="center"> | ||
|
|
@@ -84,7 +84,7 @@ | |
|
|
||
| ## Demo ⚡ | ||
|
|
||
| **Live Instances**: [Demo 1](https://demo.live-ship.vercel.app) (Live Demo) ┆ [Demo 2](https://live-ship.vercel.app) (Shipyard Links) ┆ [Demo 3](https://dev.live-ship.vercel.app) (Dev Preview) | ||
|
Contributor
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win ✅ Runtime observed🏁 Script executed: #!/bin/bash
set -euo pipefail
for url in \
https://demo.live-ship.vercel.app \
https://live-ship.vercel.app \
https://dev.live-ship.vercel.app \
https://live-ship.vercel.app/docs
do
code="$(curl -L -sS -o /dev/null -w '%{http_code}' --max-time 15 "$url")"
case "$code" in
2??|3??) echo "$code $url" ;;
*) echo "unexpected HTTP status $code for $url" >&2; exit 1 ;;
esac
doneRepository: khulnasoft/shipyard Length of output: 194 🏁 Script executed: #!/bin/bash
set +e
printf '%s\n' '--- README context ---'
sed -n '1,12p;80,92p' README.md
printf '%s\n' '--- repository-owned deployment bindings ---'
find . -maxdepth 2 -type f \( -name 'vercel.json' -o -name 'package.json' -o -name 'next.config.*' -o -name 'netlify.toml' \) -print
printf '%s\n' '--- hostname probes ---'
for url in \
https://demo.live-ship.vercel.app \
https://live-ship.vercel.app \
https://dev.live-ship.vercel.app \
https://live-ship.vercel.app/docs
do
printf '%s: ' "$url"
curl -L -sS -o /dev/null -w 'http=%{http_code} remote=%{remote_ip} exit=%{exitcode}\n' \
--connect-timeout 5 --max-time 15 "$url"
doneRepository: khulnasoft/shipyard Length of output: 1963 🏁 Script executed: #!/bin/bash
set +e
printf '%s\n' '--- changed files ---'
git diff --name-only
printf '%s\n' '--- deployment configuration ---'
cat netlify.toml
printf '%s\n' '--- DNS resolution ---'
for host in demo.live-ship.vercel.app live-ship.vercel.app dev.live-ship.vercel.app; do
printf '%s: ' "$host"
getent ahosts "$host" 2>&1 | head -n 3
done
printf '%s\n' '--- direct HTTPS probes without proxy ---'
for url in \
https://demo.live-ship.vercel.app \
https://live-ship.vercel.app \
https://dev.live-ship.vercel.app \
https://live-ship.vercel.app/docs
do
printf '%s: ' "$url"
curl --noproxy '*' -L -sS -o /dev/null \
-w 'http=%{http_code} remote=%{remote_ip} exit=%{exitcode}\n' \
--connect-timeout 5 --max-time 15 "$url"
doneRepository: khulnasoft/shipyard Length of output: 2285 Fix the published demo links before merging. DNS resolves for all three hosts, but 🤖 Prompt for AI Agents |
||
|
|
||
| **Screenshots**: Checkout the [Showcase](./docs/showcase.md), to see example dashboards from the community | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "Shipyard", | ||
| "website": "https://live-ship.vercel.app/", | ||
| "description": "A Dashboard for your Homelab 🚀", | ||
| "repository": "https://github.com/khulnasoft/shipyard", | ||
| "logo": "https://raw.githubusercontent.com/khulnaSoft/shipyard/master/docs/assets/logo.png", | ||
|
|
@@ -14,4 +14,4 @@ | |
| "khulnasoft" | ||
| ], | ||
| "stack": "heroku-20" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| <br/> | ||
| <img width="120" src="https://i.ibb.co/yhbt6CY/shipyard.png" /> | ||
| <br/> | ||
| <b><a href="https://github.com/khulnaSoft/shipyard/blob/master/docs/showcase.md">User Showcase</a></b> | <b><a href="https://demo.live-ship.vercel.app">Live Demo</a></b> | <b><a href="https://github.com/khulnaSoft/shipyard/blob/master/docs/quick-start.md">Getting Started</a></b> | <b><a href="https://live-ship.vercel.app/docs">Documentation</a></b> | <b><a href="https://github.com/khulnaSoft/shipyard">GitHub</a></b> | ||
| <br/><br/> | ||
| <a href="https://github.com/awesome-selfhosted/awesome-selfhosted#personal-dashboards"> | ||
| <img src="https://cdn.rawgit.com/sindresorhus/awesome/d7305f38d29fed78fa85652e3a63e154dd8e8829/media/badge.svg" alt="Awesome Self-Hosted"> | ||
|
|
@@ -51,7 +51,7 @@ | |
|
|
||
| ## Demo ⚡ | ||
|
|
||
| **Live Instances**: [Demo 1](https://demo.live-ship.vercel.app) (Live Demo) ┆ [Demo 2](https://live-ship.vercel.app) (Shipyard Links) ┆ [Demo 3](https://dev.live-ship.vercel.app) (Dev Preview) | ||
|
|
||
| **Screenshots**: Checkout the [Showcase](https://github.com/khulnaSoft/shipyard/blob/master/docs/showcase.md), to see example dashboards from the community | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ When a PR is opened: | |
|
|
||
| After the PR is merged: | ||
|
|
||
| - The app is build, and deployed to: <https://dev.live-ship.vercel.app> | ||
| - A new tag in GitHub is created, using the apps version number (from the package.json) | ||
| - The Docker container is built, and published under the `:latest` tag on DockerHub and GHCR | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,7 +124,7 @@ | |
|
|
||
| > By [@KhulnaSoft-bot](https://github.com/khulnasoft) | ||
|
|
||
| > A dashboard I made to manage all project development links from one place. View demo at [live-ship.vercel.app](https://live-ship.vercel.app/). | ||
|
|
||
|  | ||
|
|
||
|
|
@@ -164,7 +164,7 @@ | |
|
|
||
| ## Shipyard Example | ||
|
|
||
| > An example dashboard, by [@KhulnaSoft-bot](https://github.com/khulnasoft). View live at [demo.live-ship.vercel.app](https://demo.live-ship.vercel.app/). | ||
|
|
||
|  | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ | |
| ### Possible Issue 1: Unable to call save endpoint from CDN/static server | ||
| If you're running Shipyard using a static hosting provider (like Vercel), then there is no Node server, and so the save config action will not work via the UI. | ||
| You'll instead need to copy the YAML after making your changes, and paste that into your `conf.yml` directly. If you've connected Vercel to git, then these changes will take effect automatically, once you commit your changes. | ||
| Look here for more information: [https://live-ship.vercel.app/docs/deployment#deploy-to-cloud-service](https://live-ship.vercel.app/docs/deployment#deploy-to-cloud-service) | ||
|
|
||
| If you're running on Netlify, there are some cloud functions which take care of all the server endpoints (like status checking), so these will work as expected. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,4 +44,3 @@ | |
| [headers.values] | ||
| # Uncomment to enable Netlify user control. Requires premium plan. | ||
| # Basic-Auth = "someuser:somepassword anotheruser:anotherpassword" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "shipyard", | ||
| "version": "3.1.5", | ||
| "author": "KhulnaSoft Dev <info@khulnasoft.com> (https://khulnasoft.com)", | ||
| "license": "MIT", | ||
| "scripts": { | ||
|
|
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |
| <!-- Source and Docs Links --> | ||
| <h3>{{ $t('app-info.more-info') }}</h3> | ||
| {{ $t('app-info.source') }}: <a href="https://github.com/khulnasoft/shipyard">github.com/khulnasoft/shipyard</a><br> | ||
| {{ $t('app-info.documentation') }}: <a href="https://live-ship.vercel.app/docs">live-ship.vercel.app/docs</a> | ||
| <!-- Privacy & Security --> | ||
| <h3>{{ $t('app-info.privacy-and-security') }}</h3> | ||
| {{ $t('app-info.privacy-and-security-l1') }} <a href="https://github.com/khulnaSoft/shipyard/blob/master/docs/privacy.md">{{ $t('app-info.privacy-and-security-privacy-policy') }}</a>.<br> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
| </p> | ||
| {{ $t('interactive-editor.edit-app-config.warning-msg-l1') }} | ||
| {{ $t('interactive-editor.edit-app-config.warning-msg-l2') }} | ||
| <a href="https://live-ship.vercel.app/docs/configuring#appconfig-optional"> | ||
| {{ $t('interactive-editor.edit-app-config.warning-msg-docs') }} | ||
| </a> | ||
| {{ $t('interactive-editor.edit-app-config.warning-msg-l3') }} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: The displayed setup-guide URL ends in
/docs, but the hyperlink target ishttps://live-ship.vercel.app/, so users clicking the documentation link are sent to the site root instead of the documentation page.Suggested fix: Change the hyperlink target to
https://live-ship.vercel.app/docsor make the displayed URL match the target.