Skip to content

DISC-263: Percentage funded displayed text lacking animation #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arkariang merged 2 commits into from
Jun 18, 2026
+5 −1
Merged

DISC-263: Percentage funded displayed text lacking animation #2535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9cdcfe
- Displayed text on progress indicator is now animated instead of jum…
Arkariang Jun 17, 2026
d785cbe
Merge branch 'master' of github.com:kickstarter/android-oss into imar…
Arkariang Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/main/java/com/kickstarter/ui/compose/designsystem/KSProgressIndicators.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ import com.kickstarter.ui.compose.designsystem.videoplayer.icons.Check
import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.delay
import kotlinx.coroutines.launch
import kotlin.math.roundToInt

@Composable
@Preview(name = "Light", uiMode = Configuration.UI_MODE_NIGHT_NO)
Expand Down Expand Up @@ -307,9 +308,12 @@ fun KSVideoProgressIndicator(

// Text overlay (shown during progress phase only). Decorative for accessibility
if (phase == 0 && text.isNotEmpty()) {
val coercedTarget = targetProgress.coerceIn(0f, 1f)
val sweepFraction = if (coercedTarget > 0f) (animatedProgress / coercedTarget).coerceIn(0f, 1f) else 0f
val displayText = text.toIntOrNull()?.let { (it * sweepFraction).roundToInt().toString() } ?: text
Comment thread
Arkariang marked this conversation as resolved.
Text(
modifier = Modifier.clearAndSetSemantics { },
text = text,
text = displayText,
color = baseColor,
style = typographyV2.bodyBoldXS.copy(fontSize = 12.sp)
)
Expand Down