feat(LAB-4574): remove notification methods from the SDK

mkdocs.yml

@@ -23,7 +23,6 @@ nav:
           - Label Utils: sdk/label_utils.md
           - Label Parsing: sdk/label_parsing.md
           - LLM: sdk/llm.md
-          - Notification: sdk/notification.md
           - Organization: sdk/organization.md
           - Plugins: sdk/plugins.md
           - Project: sdk/project.md

src/kili/adapters/kili_api_gateway/notification/mappers.py

@@ -1,14 +1,8 @@
 """Mappers for notification API calls."""
 
-
-from kili.adapters.kili_api_gateway.user.mappers import user_where_mapper
 from kili.domain.notification import NotificationFilter
 
 
 def map_notification_filter(filters: NotificationFilter) -> dict:
     """Build the GraphQL NotificationWhere variable to be sent in an operation."""
-    return {
-        "hasBeenSeen": filters.has_been_seen,
-        "id": filters.id,
-        "user": user_where_mapper(filters.user) if filters.user else None,
-    }
+    return {"id": filters.id}

src/kili/adapters/kili_api_gateway/notification/operations_mixin.py

@@ -28,8 +28,3 @@ def list_notifications(
         return PaginatedGraphQLQuery(self.graphql_client).execute_query_from_paginated_call(
             query, where, options, "Retrieving notifications", GQL_COUNT_NOTIFICATIONS
         )
-
-    def count_notification(self, filters: NotificationFilter) -> int:
-        """Count notifications."""
-        variables = {"where": map_notification_filter(filters=filters)}
-        return self.graphql_client.execute(GQL_COUNT_NOTIFICATIONS, variables)["data"]

src/kili/client.py

@@ -15,7 +15,6 @@
 from kili.core.graphql.graphql_client import GraphQLClient, GraphQLClientName
 from kili.entrypoints.mutations.asset import MutationsAsset
 from kili.entrypoints.mutations.issue import MutationsIssue
-from kili.entrypoints.mutations.notification import MutationsNotification
 from kili.entrypoints.mutations.plugins import MutationsPlugins
 from kili.entrypoints.mutations.project import MutationsProject
 from kili.entrypoints.mutations.project_version import MutationsProjectVersion
@@ -31,7 +30,6 @@
 from kili.presentation.client.internal import InternalClientMethods
 from kili.presentation.client.issue import IssueClientMethods
 from kili.presentation.client.label import LabelClientMethods
-from kili.presentation.client.notification import NotificationClientMethods
 from kili.presentation.client.organization import OrganizationClientMethods
 from kili.presentation.client.project import ProjectClientMethods
 from kili.presentation.client.project_workflow import ProjectWorkflowClientMethods
@@ -63,7 +61,6 @@ def filter(self, record) -> bool:
 class Kili(  # pylint: disable=too-many-ancestors,too-many-instance-attributes
     MutationsAsset,
     MutationsIssue,
-    MutationsNotification,
     MutationsPlugins,
     MutationsProject,
     MutationsProjectVersion,
@@ -75,7 +72,6 @@ class Kili(  # pylint: disable=too-many-ancestors,too-many-instance-attributes
     CloudStorageClientMethods,
     IssueClientMethods,
     LabelClientMethods,
-    NotificationClientMethods,
     OrganizationClientMethods,
     ProjectClientMethods,
     ProjectWorkflowClientMethods,

src/kili/core/enums.py

@@ -18,13 +18,6 @@
 ]
 
 
-NotificationStatus = Literal[
-    "FAILURE",
-    "PENDING",
-    "SUCCESS",
-]
-
-
 OrganizationRole = Literal[
     "ADMIN",
     "USER",

src/kili/domain/notification.py

@@ -1,10 +1,7 @@
 """Notification domain."""
 
 from dataclasses import dataclass
-from typing import TYPE_CHECKING, NewType, Optional
-
-if TYPE_CHECKING:
-    from .user import UserFilter
+from typing import NewType, Optional
 
 NotificationId = NewType("NotificationId", str)
 
@@ -13,6 +10,4 @@
 class NotificationFilter:
     """Notification filter."""
 
-    has_been_seen: Optional[bool]
     id: Optional[NotificationId]
-    user: Optional["UserFilter"]

src/kili/services/asset_import/base.py

@@ -31,6 +31,7 @@
 )
 from kili.core.helpers import T, format_result, get_mime_type, is_url
 from kili.core.utils.pagination import batcher
+from kili.domain.notification import NotificationFilter, NotificationId
 from kili.domain.organization import OrganizationFilters
 from kili.domain.project import InputType, ProjectId
 from kili.domain.types import ListOrTuple
@@ -139,7 +140,13 @@ def verify_batch_imported(self, notification_id: str) -> None:
             reraise=True,
         ):
             with attempt:
-                notification = self.kili.notifications(notification_id=notification_id)[0]
+                notification = list(
+                    self.kili.kili_api_gateway.list_notifications(
+                        filters=NotificationFilter(id=NotificationId(notification_id)),
+                        fields=("status",),
+                        options=QueryOptions(disable_tqdm=True, first=1, skip=0),
+                    )
+                )[0]
                 if notification["status"] == "FAILURE":
                     error_message = (
                         "Some assets were not imported. "