docs: point request.hostname URL link at current Node.js docs - #1994
docs: point request.hostname URL link at current Node.js docs#1994FirmaSpring wants to merge 1 commit into
Conversation
The link targeted the Node 8 docs snapshot (nodejs.org/dist/latest-v8.x/...), but Koa requires node >= 18 per package.json engines, and Node 8 is EOL. Link the WHATWG URL API section of the current docs instead. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Koa request.hostname documentation to link to the current Node.js WHATWG URL API instead of an outdated Node 8 snapshot. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Merge Risk: ⚪ Minimal · up to This is a localized documentation-only link update with no runtime or product behavior change, so no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1994 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 9 9
Lines 2109 2109
=======================================
Hits 2107 2107
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Copied from human-written text in #1995 The link update change and summation are correct! 👍
|
Problem
docs/api/request.md(request.hostname) links the WHATWG URL API atThat is the Node.js 8 documentation snapshot. Node 8 has been EOL since 2019, and Koa itself requires
node >= 18(package.jsonengines). New WHATWG URL features referenced by current Koa behavior (e.g.URLavailable globally,url.URLparsing used for IPv6 hostnames) are documented in the current docs, not the Node 8 snapshot.Solution
Link to the current WHATWG URL API section:
Verification
curl -L -o /dev/null -w "%{http_code}"returns 200 for the new URL.#the-whatwg-url-apiexists on the page (section "The WHATWG URL API").grep -n "engines" -A2 package.jsonshows"node": ">= 18".Summary by Sourcery
Documentation:
Summary by CodeRabbit
request.hostnamedocumentation link to reference the current Node.js URL API documentation.