Skip to content

bugfix: Fix e2e test resources android #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malliaridis merged 3 commits into from
Jul 22, 2026
+9 −2
Merged

bugfix: Fix e2e test resources android #2380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1c87ec
Fix missing resources from shared module
malliaridis Jul 16, 2026
8a04a42
Fix invalid path for android application
malliaridis Jul 16, 2026
3e4093b
Fix jvm main class package missmatch
malliaridis Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions e2e/e2e-test/androidApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ android {
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
}

// TODO Consider moving this to the shared module or the korge plugin configurations
Comment thread
malliaridis marked this conversation as resolved.
sourceSets {
getByName("main") {
assets.directories.add("../shared/src/commonMain/resources")
}
}

// Ignore most of the configuration like packaging and signing, as we do not care in e2e tests
packaging {
resources {
Expand Down
2 changes: 1 addition & 1 deletion e2e/e2e-test/androidApp/src/main/kotlin/org/korge/e2e/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class MainActivity : KorgwActivity(config = GameWindowCreationConfig(msaa = 1, f
)

Log.d(TAG, "Determining screenshotsVfs...")
val path = Environment["OUTPUT_DIR"] ?: "."
val path = applicationContext.getExternalFilesDir(null)!!.absolutePath

@augmentcode augmentcode Bot Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e/e2e-test/androidApp/src/main/kotlin/org/korge/e2e/MainActivity.kt:33 — getExternalFilesDir(null) can return null when external storage isn’t currently mounted; the !! will crash the e2e app and prevent screenshot capture in that case.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Log.d(TAG, "Determining screenshotsVfs... $path")
val screenshotsVfs = localVfs(path).also { it.mkdirs() }.jail()
Log.d(TAG, "vfs: $screenshotsVfs")
Expand Down
2 changes: 1 addition & 1 deletion e2e/e2e-test/desktopApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ korge {

targetJvm()

jvmMainClassName = "org.korge.e2e.RefMainKt"
jvmMainClassName = "org.korge.e2e.jvm.RefMainKt"
}

kotlin {
Expand Down
Loading