Parametrizing vapor_wrapper.groovy lock (RHELHA-1045) - #51
Conversation
|
To parametrize the vapor_wrapper I decided to create a Semaphore structure. For that I have extracted functionality from RWLock and put it into different files, so Semaphore could access it. Functionality of the RWLock is still the same. |
aa1e2fe to
6ce0407
Compare
|
Having looked at this more carefully I don't hate it quite as much as I did last week, but I still think it's huge overkill to completely refactor a central pillar of the CI to please a small (optional) corner of it. I reckon it's possible to add a parameter or a polymorph to RWLock to allow it to to TryAcquire, and then use that in the semaphore. It might look slightly less pretty in the Semaphore code or run slightly slower, but it's protecting things that can take an hour to run... |
9f6c53a to
b694d56
Compare
|
Original RWLock.groovy is unchanged right now, though some duplicity exists. |
f28afad to
737d0c6
Compare
737d0c6 to
a4546fa
Compare
2 participants
No description provided.