feat(chart): manage Traefik Middleware CRs from values (v0.4.0) - #6
Merged
Conversation
…v0.4.0) Allow the chart to manage Traefik Middleware CRs via a generic ingress.middlewares list instead of requiring a separate manifests Application. Includes helm-unittest coverage and a chart version bump to 0.4.0.
Rework the cross-namespace Role/RoleBinding test: containsDocument with any: true for namespace-scoped existence, assertion-level documentSelector (kind=Role, matchMany) for verb checks. Fixes the pre-existing failure under helm-unittest v1.1.2 semantics.
Document ingress.middlewares in the chart README and docs/domains.md; vendor the Traefik Middleware schema and add an ingress-traefik render case to scripts/validate.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renders
MiddlewareCRs from a genericingress.middlewareslist so users no longer need a separate manifests Application for the Traefik strip-prefix middleware.templates/middlewares.yaml: renderstraefik.io/v1alpha1Middleware per entry (name+specrequired, spec passed through verbatim)values.yaml:ingress.middlewares: []with a strip-prefix exampletests/middlewares_test.yaml: 8 new helm-unittest casestests/rbac_test.yaml: fixes the pre-existing cross-namespace suite for helm-unittest v1.1.2 (containsDocumentany: true)scripts/validate.sh+scripts/schemas/middleware.json: kubeconform validation for the new render case0.3.3 → 0.4.0(new capability; appVersion stays 0.3.0), README + docs updated