✨ Support VLAN sub-interface configuration for supervisor VSphereMachine#3956
Conversation
|
Hi @shutingm-kubernetes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR introduces a feature of VLAN Subinterface for supervisor based VSphereMachine, users can create VLAN sub-interfaces on top of secondary network interfaces. The actual VLAN sub-interface configuration is delegated to vm-operator via the VirtualMachine.spec.network.vlans field in the v1alpha6 schema.
User-facing API changes
Example:
Testing Done
Steps:
Result:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #