dra: codeorg: simplify device attributes#66
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Mar 9, 2026
Merged
dra: codeorg: simplify device attributes#66k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
Author
|
this is trivial enough that can fit in 0.1.0 or can be delayed to 0.2.0. |
ffromani
force-pushed
the
device-attr-refactor
branch
from
4500555 to
50f2b74
Compare
Contributor
|
Thanks. /lgtm /hold (to sync with #65) |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
finally found the reason for apparently random precommit lane failures: #70 |
pravk03
reviewed
Mar 6, 2026
| coreID := int64(cpu.CoreID) | ||
| cpuID := int64(cpu.CpuID) | ||
| coreType := cpu.CoreType.String() | ||
| deviceAttrs := map[resourceapi.QualifiedName]resourceapi.DeviceAttribute{ |
Contributor
There was a problem hiding this comment.
nit: maybe we can also add dra.cpu/smtEnabled here ?. Not sure why we missed earlier.
Contributor
|
/lgtm |
remove temporary variables and add a function whose purpose is to add attributes to enable compatibility with other relevant DRA drivers (dranet for now). We will keep this function until all the attributes we need get standardized in kubernetes core - or any other mechanism the community will pick. Unfortunately, at the moment the only way to be compatible with nonstandard attribute is crosscheck from both sides (driver <=> driver) creating a dense compatibility matrix. This is awkward and scales poorly but it's all we have for the time being. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
device-attr-refactor
branch
from
50f2b74 to
b3e110a
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
Author
|
/hold cancel this is a QoL improvement till we have #68 |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm Thanks !! |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove temporary variables and add a function whose purpose is to add attributes to enable compatibility with other relevant DRA drivers (dranet for now).
We will keep this function until all the attributes we need get standardized in kubernetes core - or any other mechanism the community will pick.
Unfortunately, at the moment the only way to be compatible with nonstandard attribute is crosscheck from both sides (driver <=> driver) creating a dense compatibility matrix.
This is awkward and scales poorly but it's all we have atm.