Update the bundle version for VAP and add it as a release step.#4759
Update the bundle version for VAP and add it as a release step.#4759bexxmodd wants to merge 8 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bexxmodd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
/retest |
k8s-ci-robot
added
size/S
|
@mikemorris: GitHub didn't allow me to request PR reviews from the following users: jaiveerk. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/M
kflynn
left a comment
kflynn
left a comment
There was a problem hiding this comment.
My only concern here is allowing v0 tags in the Standard-channel VAP, which is a bit of a strange concern in practice, but take a look. 🙂 Thanks for jumping on this! 🙂
| - expression: | | ||
| object.spec.group != 'gateway.networking.k8s.io' || | ||
| (has(object.metadata.annotations) && object.metadata.annotations.exists(k, k == 'gateway.networking.k8s.io/bundle-version') && | ||
| (object.metadata.annotations['gateway.networking.k8s.io/bundle-version'] == 'v0.0.0-dev' || | ||
| (object.metadata.annotations['gateway.networking.k8s.io/bundle-version'].startsWith('v1.') && | ||
| !matches(object.metadata.annotations['gateway.networking.k8s.io/bundle-version'], '^v1\\.[0-4](\\.|$)')))) | ||
| message: "Installing CRDs with version other than v0.0.0-dev or v1.5+ is prohibited by default. Uninstall ValidatingAdmissionPolicy safe-upgrades.gateway.networking.k8s.io to install other versions." |
There was a problem hiding this comment.
I don't think we should treat v0 tags specially here, right? If you're already on Standard channel, you shouldn't be able to install a monthly over it -- and I realize that that looks odd, but monthlies don't include this resource at all (unless I'm really wrong) so this will only come up if you've installed with the resources on main, which... you shouldn't be doing. 🙂
There was a problem hiding this comment.
v0.0.0-dev is only handled in experimental vap now.
| {"v1.0.0", true}, | ||
| {"v1.1.0", true}, | ||
| {"v1.3.0", true}, | ||
| {"v0.0.0-dev", false}, |
There was a problem hiding this comment.
Likewise I feel like this should be channel-dependent...
There was a problem hiding this comment.
Updated tests to test for each channel separately.
k8s-ci-robot
added
size/L
|
/retest |
5 participants
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #4739
Does this PR introduce a user-facing change?: