Skip to content

Update the bundle version for VAP and add it as a release step.#4759

Open
bexxmodd wants to merge 8 commits intokubernetes-sigs:mainfrom
bexxmodd:vap/semver1
Open

Update the bundle version for VAP and add it as a release step.#4759
bexxmodd wants to merge 8 commits intokubernetes-sigs:mainfrom
bexxmodd:vap/semver1

Conversation

@bexxmodd
Copy link
Copy Markdown
Contributor

@bexxmodd bexxmodd commented Apr 15, 2026

What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #4739

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2026
@youngnick
Copy link
Copy Markdown
Contributor

youngnick commented Apr 16, 2026

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2026
mikemorris
mikemorris reviewed Apr 16, 2026
View reviewed changes
Comment thread config/crd/standard/gateway.networking.k8s.io_vap_safeupgrades.yaml Outdated
@k8s-ci-robot k8s-ci-robot requested a review from kflynn April 16, 2026 19:23
mikemorris
mikemorris reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikemorris mikemorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @jaiveerk @kflynn

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 16, 2026

@mikemorris: GitHub didn't allow me to request PR reviews from the following users: jaiveerk.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @jaiveerk @kflynn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2026
kflynn
kflynn requested changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is allowing v0 tags in the Standard-channel VAP, which is a bit of a strange concern in practice, but take a look. 🙂 Thanks for jumping on this! 🙂

Comment thread config/crd/standard/gateway.networking.k8s.io_vap_safeupgrades.yaml Outdated
Comment thread tests/vap/vap_test.go Outdated
Comment thread RELEASE.md
Comment thread RELEASE.md
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2026
@bexxmodd
Copy link
Copy Markdown
Contributor Author

bexxmodd commented Apr 20, 2026

/retest

@kflynn kflynn self-requested a review April 23, 2026 15:54
kflynn
kflynn approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm good with this now, thanks @bexxmodd! 🙂

@kflynn
Copy link
Copy Markdown
Contributor

kflynn commented Apr 23, 2026

/lgtm
/approve

(not that I think those'll both work 😂)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bexxmodd, kflynn
Once this PR has been reviewed and has the lgtm label, please assign rikatz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kflynn kflynn kflynn approved these changes

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

+1 more reviewer

@mikemorris mikemorris mikemorris left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kflynn kflynn

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Bundle Version Annotation on VAP/VAPB for Gateway 1.5.1

5 participants

@bexxmodd @youngnick @k8s-ci-robot @kflynn @mikemorris