Skip to content

ARM64 support for MaaS#1912

Open
kreeuwijk wants to merge 1 commit intokubernetes-sigs:mainfrom
kreeuwijk:maas-arm64
Open

ARM64 support for MaaS#1912
kreeuwijk wants to merge 1 commit intokubernetes-sigs:mainfrom
kreeuwijk:maas-arm64

Conversation

@kreeuwijk
Copy link
Copy Markdown
Contributor

@kreeuwijk kreeuwijk commented Jan 14, 2026

Change description

This PR adds the ability to generate Ubuntu 22.04/24.04 ARM64 images.

The work is inspired by this work from @ader1990. While that PR was never merged, this PR generalizes the approach and ensures no impact to existing workflows.

  • Is this change including a new Provider or a new OS? (y/n) N

Related issues

Additional context

images/capi/packer/maas/README.md has been updated to detail the build steps fully for both AMD64 and ARM64.

Acknowledgements

Kudos to @blik616287 for helping out with the Ansible filtering

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 14, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kreeuwijk / name: Kevin Reeuwijk (f3af927)

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @kreeuwijk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 14, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/contains-merge-commits cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 14, 2026
@drew-viles
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2026
@kreeuwijk
Copy link
Copy Markdown
Contributor Author

kreeuwijk commented Jan 15, 2026

pull-azure-sigs has no relevance to the PR

@vasartori
Copy link
Copy Markdown
Contributor

I don't have ARM64 hardware available to test this PR. However, based on my review, this PR will not break anything for amd64 builds.
I am starting tests on amd64 right now.

@ader1990
Copy link
Copy Markdown
Contributor

Thanks for spearheading this work!

@vasartori
Copy link
Copy Markdown
Contributor

Tested! Everything seems to work well on amd64.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2026
@vasartori
Copy link
Copy Markdown
Contributor

/approve

@kreeuwijk
Copy link
Copy Markdown
Contributor Author

@vasartori for completeness: I used an AWS Graviton instance (m7g.metal) to test this in ARM64. The changes allowed me to generate CAPI images for Ubuntu 22.04 and 24.04. I also tested deploying a CAPI cluster through MaaS (using Spectro Cloud Palette) with the ARM64 Ubuntu 22.04 + Kubernetes 1.33.5 image and that worked.

I did find a bug in MaaS itself though, which has been reported here

Comment thread images/capi/packer/goss/goss-vars.yaml Outdated
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2026
@vasartori
Copy link
Copy Markdown
Contributor

@kreeuwijk Would you mind squashing the commits please?

@kreeuwijk
Copy link
Copy Markdown
Contributor Author

@vasartori Commits squashed

@vasartori
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vasartori
Once this PR has been reviewed and has the lgtm label, please assign jsturtevant for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vasartori
Copy link
Copy Markdown
Contributor

@drew-viles could you help us to merge this PR?

@drew-viles
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@vasartori
Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@kreeuwijk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azure-vhds f3af927 link true /test pull-azure-vhds
pull-azure-sigs f3af927 link false /test pull-azure-sigs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@drew-viles
Copy link
Copy Markdown
Contributor

So in principle I've no issues with merging this. My only concern is it'll cause issues with the azure tests moving forward. This is where my knowledge of the repo and subsequent prow usage falters tbh. I'm going to ask @mboersma if he can chip in on how we can target it in a way that skips the azure checks. I'm sure there is as there are some build that only use Azure for example, and they only run those checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants