Conversation
|
|
|
Hi @kreeuwijk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
|
|
I don't have ARM64 hardware available to test this PR. However, based on my review, this PR will not break anything for amd64 builds. |
|
Thanks for spearheading this work! |
|
Tested! Everything seems to work well on amd64. |
|
/approve |
|
@vasartori for completeness: I used an AWS Graviton instance ( I did find a bug in MaaS itself though, which has been reported here |
|
@kreeuwijk Would you mind squashing the commits please? |
|
@vasartori Commits squashed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vasartori The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@drew-viles could you help us to merge this PR? |
|
/retest |
1 similar comment
|
/retest |
|
@kreeuwijk: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
So in principle I've no issues with merging this. My only concern is it'll cause issues with the azure tests moving forward. This is where my knowledge of the repo and subsequent prow usage falters tbh. I'm going to ask @mboersma if he can chip in on how we can target it in a way that skips the azure checks. I'm sure there is as there are some build that only use Azure for example, and they only run those checks. |
Change description
This PR adds the ability to generate Ubuntu 22.04/24.04 ARM64 images.
The work is inspired by this work from @ader1990. While that PR was never merged, this PR generalizes the approach and ensures no impact to existing workflows.
Related issues
Additional context
images/capi/packer/maas/README.md has been updated to detail the build steps fully for both AMD64 and ARM64.
Acknowledgements
Kudos to @blik616287 for helping out with the Ansible filtering