Skip to content

upgrade ansible-lint to a newer version#1935

Closed
ffais wants to merge 0 commit intokubernetes-sigs:mainfrom
ffais:upgrade-ansible-lint
Closed

upgrade ansible-lint to a newer version#1935
ffais wants to merge 0 commit intokubernetes-sigs:mainfrom
ffais:upgrade-ansible-lint

Conversation

@ffais
Copy link
Copy Markdown
Contributor

@ffais ffais commented Feb 17, 2026

Change description

Upgrade ansible-lint to a newer version 26.1.1.

There're some rule violations, but they should be resolved in another PR.

# Rule Violation Summary

  1 syntax-check profile:min tags:core,unskippable
 68 var-naming profile:min tags:idiom
 21 fqcn profile:min tags:formatting

Related issues

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @ffais. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2026
Copy link
Copy Markdown
Contributor

@drew-viles drew-viles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2026
@ffais
Copy link
Copy Markdown
Contributor Author

ffais commented Feb 19, 2026

The pull-lint tests fail due to an incompatibility between ansible-core and ansible-lint. Ansible-core is too old. As soon as one of these two PRs #1925 #1894 is merged, I'll proceed with the rebase.

I did some tests locally with both version 2.16.16 and 2.20.0 and everything works perfectly.

@ffais ffais force-pushed the upgrade-ansible-lint branch from b5aee1f to 0767290 Compare February 25, 2026 17:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@ffais: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lint 0767290 link true /test pull-lint
pull-gcp-all 0767290 link true /test pull-gcp-all
pull-azure-sigs 0767290 link false /test pull-azure-sigs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffais ffais closed this Feb 25, 2026
@ffais ffais force-pushed the upgrade-ansible-lint branch from 0767290 to d7289b5 Compare February 25, 2026 18:15
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ansible-lint to a newer version

4 participants