hack: ensure py3 user local bin is checked and used accordingly#1945
hack: ensure py3 user local bin is checked and used accordingly#1945egypcio wants to merge 5 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @egypcio! |
|
Hi @egypcio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
* get-pip.py is used to bootstrap pip3 only Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
* pip3_install used --user parameter before, so they assumed things
were installed under $HOME/.local/bin already;
* apply changes to allow `make deps` to get a bit further without
depending on root privileges;
* check that we are NOT running as 'root' before using
--break-system-packages with pip3 (not done before).
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
93bc689 to
b6939e4
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change description
by merging these changes, we:
pip3undercapi/in git;make depsto get a bit further without depending on root privileges;$HOME/.local/bin, oncepip3_installused --user parameter already;--break-system-packageswithpip3(not done before);ansiblecommands as variables, respecting local PATH under$HOME/.local/binif binary exists;packerto be installed under$HOME/.local/binto get a sharp and consistent use of$PATH.are these changes related to new provider or OS?
Related issues
no issues or PR are affected by these changes
Additional context
there's no need to run
make depswith root privileges. therefore the possibility of installing local user binaries was taking to consideration here.on top of that, the code in upstream repository would be taking care of setting up dependencies for end users in a more convenient way -- e.g.: they would no longer need additional steps to install
pip3oransibleusingsudo.Next steps
should this be merged:
PATHwhile building images;PATH=$HOME/.local/bin:$PATH make ...