Add proxmox windows #1976
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| # Copyright 2026 The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Apply Proxmox NoCloud network data from a config-drive file.""" | ||
|
|
||
| import logging | ||
| import os | ||
| import string | ||
| import sys | ||
|
|
||
| try: | ||
| from oslo_log import log as oslo_logging | ||
|
|
||
| LOG = oslo_logging.getLogger(__name__) | ||
| except Exception: # pragma: no cover - fallback when oslo logging is unavailable | ||
| logging.basicConfig(level=logging.INFO) | ||
| LOG = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| DEFAULT_NETWORK_DATA_FILENAMES = ("NETWORK_CONFIG", "network-config") | ||
|
|
||
|
|
||
| def _iter_search_roots(): | ||
| search_roots = os.environ.get("PROXMOX_NETWORK_DATA_SEARCH_ROOTS") | ||
| if search_roots: | ||
| for root in search_roots.split(os.pathsep): | ||
| root = root.strip() | ||
| if root: | ||
| yield root | ||
| return | ||
|
|
||
| for drive_letter in string.ascii_uppercase: | ||
| yield "%s:\\" % drive_letter | ||
|
|
||
|
|
||
| def _iter_candidate_paths(): | ||
| override_path = os.environ.get("PROXMOX_NETWORK_DATA_PATH", "").strip() | ||
| if override_path: | ||
| yield override_path | ||
| return | ||
|
|
||
| for root in _iter_search_roots(): | ||
| normalized_root = root.rstrip("\\/") | ||
| for filename in DEFAULT_NETWORK_DATA_FILENAMES: | ||
| yield "%s\\%s" % (normalized_root, filename) | ||
|
|
||
|
|
||
| def find_network_data_path(path_exists=os.path.exists): | ||
| for candidate_path in _iter_candidate_paths(): | ||
| if path_exists(candidate_path): | ||
| return candidate_path | ||
| return None | ||
|
|
||
|
|
||
| def load_network_data(network_data_path, open_file=open, parser=None): | ||
| if parser is None: | ||
| from cloudbaseinit.utils import serialization | ||
|
|
||
| parser = serialization.parse_json_yaml | ||
|
|
||
| with open_file(network_data_path, "r", encoding="utf-8") as network_data_file: | ||
| raw_network_data = network_data_file.read() | ||
|
|
||
| network_data = parser(raw_network_data) | ||
| if not isinstance(network_data, dict): | ||
| raise ValueError( | ||
| "Proxmox network data parsed into %r, expected dict" % | ||
| type(network_data) | ||
| ) | ||
|
|
||
| return network_data | ||
|
|
||
|
|
||
| def apply_network_data(network_data, network_parser=None, plugin_factory=None): | ||
| if network_parser is None: | ||
| from cloudbaseinit.metadata.services.nocloudservice import ( | ||
| NoCloudNetworkConfigParser, | ||
| ) | ||
|
|
||
| network_parser = NoCloudNetworkConfigParser.parse | ||
|
|
||
| if plugin_factory is None: | ||
| from cloudbaseinit.plugins.common import networkconfig | ||
|
|
||
| plugin_factory = networkconfig.NetworkConfigPlugin | ||
|
|
||
| network_details = network_parser(network_data) | ||
| if not network_details: | ||
| LOG.warning("NoCloud network parser returned no interfaces") | ||
| return False | ||
|
|
||
| plugin = plugin_factory() | ||
| process_network_details = getattr(plugin, "_process_network_details_v2", None) | ||
| if process_network_details is None: | ||
| raise AttributeError( | ||
| "Cloudbase-Init network plugin is missing _process_network_details_v2" | ||
| ) | ||
|
|
||
| process_network_details(network_details) | ||
| return True | ||
|
|
||
|
|
||
| def main(): | ||
| network_data_path = find_network_data_path() | ||
| if not network_data_path: | ||
| LOG.info( | ||
| "No Proxmox network data found in candidate paths: %s", | ||
| ", ".join(_iter_candidate_paths()), | ||
| ) | ||
| return 0 | ||
|
|
||
| try: | ||
| network_data = load_network_data(network_data_path) | ||
| except Exception: | ||
| LOG.exception( | ||
| "Failed to load Proxmox network data from %s", network_data_path | ||
| ) | ||
| return 0 | ||
|
|
||
| try: | ||
| LOG.info("Applying Proxmox network data from %s", network_data_path) | ||
| applied = apply_network_data(network_data) | ||
| except Exception: | ||
| LOG.exception( | ||
| "Failed to apply Proxmox network data from %s", network_data_path | ||
| ) | ||
| return 0 | ||
|
|
||
| if not applied: | ||
| LOG.warning( | ||
| "No network interfaces were applied from %s", network_data_path | ||
| ) | ||
|
|
||
| return 0 | ||
|
Comment on lines
+114
to
+145
Contributor
There was a problem hiding this comment. Would it not be better to fail a little louder rather than return 0 if something fails? As I'm reading this, it looks like failures will happen silently meaning an image could successfully build even if something like applying the proxmox network fails. Would we be ok with this?
Author
There was a problem hiding this comment. So this is kind of my hack to read the cloudinit network data that CAPMOX injects via a ISO-9660 cd drive for kubeadm boostrap. So this wont fail the build of the VM, as its a node first boot helper script for cloudbase-init(windows version of cloud-init). Though I should try to write to a file to troubleshoot networking incase CAPMOX changes its kubeadmbootstrap process, and be more verbose on failures. |
||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Copyright 2026 The Kubernetes Authors. | ||
|
|
||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
|
|
||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| --- | ||
| - name: Ensure Proxmox Cloudbase-Init LocalScripts directory exists | ||
| ansible.windows.win_file: | ||
| path: "{{ programfiles.stdout | trim }}\\Cloudbase Solutions\\Cloudbase-Init\\LocalScripts" | ||
| state: directory | ||
|
|
||
| - name: Copy Proxmox Cloudbase-Init compatibility helper | ||
| ansible.windows.win_copy: | ||
| src: proxmox/cloudbase_helper.py | ||
| dest: "{{ programfiles.stdout | trim }}\\Cloudbase Solutions\\Cloudbase-Init\\LocalScripts\\cloudbase_helper.py" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "ansible_common_vars": "runtime={{user `runtime`}} containerd_url={{user `containerd_url`}} containerd_sha256={{user `containerd_sha256_windows`}} containerd_version={{user `containerd_version`}} pause_image={{user `pause_image`}} additional_debug_files=\"{{user `additional_debug_files`}}\" containerd_additional_settings={{user `containerd_additional_settings`}} custom_role_names=\"{{user `custom_role_names`}}\" http_proxy={{user `http_proxy`}} https_proxy={{user `https_proxy`}} no_proxy={{user `no_proxy`}} kubernetes_base_url={{user `kubernetes_base_url`}} kubernetes_semver={{user `kubernetes_semver`}} kubernetes_install_path={{user `kubernetes_install_path`}} cloudbase_init_url=\"{{user `cloudbase_init_url`}}\" cloudbase_plugins=\"{{user `cloudbase_plugins`}}\" cloudbase_metadata_services=\"{{user `cloudbase_metadata_services`}}\" cloudbase_plugins_unattend=\"{{user `cloudbase_plugins_unattend`}}\" cloudbase_metadata_services_unattend=\"{{user `cloudbase_metadata_services_unattend`}}\" cloudbase_nocloud_metadata_file=\"{{user `cloudbase_nocloud_metadata_file`}}\" cloudbase_nocloud_networkdata_file=\"{{user `cloudbase_nocloud_networkdata_file`}}\" cloudbase_nocloud_userdata_file=\"{{user `cloudbase_nocloud_userdata_file`}}\" prepull={{user `prepull`}} windows_updates_kbs=\"{{user `windows_updates_kbs`}}\" windows_updates_categories=\"{{user `windows_updates_categories`}}\" windows_service_manager={{user `windows_service_manager`}} nssm_url={{user `nssm_url`}} distribution_version={{user `distribution_version`}} netbios_host_name_compatibility={{user `netbios_host_name_compatibility`}} disable_hypervisor={{ user `disable_hypervisor` }} cloudbase_logging_serial_port={{ user `cloudbase_logging_serial_port` }} cloudbase_real_time_clock_utc={{ user `cloudbase_real_time_clock_utc` }} load_additional_components={{ user `load_additional_components`}} ecr_credential_provider={{ user `ecr_credential_provider` }} additional_registry_images={{ user `additional_registry_images`}} additional_registry_images_list={{ user `additional_registry_images_list`}} additional_url_images={{ user `additional_url_images`}} additional_url_images_list={{ user `additional_url_images_list`}} additional_executables={{ user `additional_executables`}} additional_executables_list={{ user `additional_executables_list`}} additional_executables_destination_path={{ user `additional_executables_destination_path`}} ssh_source_url={{user `ssh_source_url` }} debug_tools={{user `debug_tools`}}" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section looks copy-pasted: the same -var-file is passed twice, and the comment references vSphere in the Proxmox path. Is the duplicate var-file intentional?