KEP-7029: LocalQueue Default Maximum Execution Time#10596
KEP-7029: LocalQueue Default Maximum Execution Time#10596kannon92 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
|
||
| ## Summary | ||
|
|
||
| Add the ability to configure a default maximum execution time on a LocalQueue. |
There was a problem hiding this comment.
We have most of the configuration on the CQ level and very very few on LQ, which acts mainly as a pointer to CQ. Why do we need to have it on LQ? How often do you face use cases where multiple LQ pointing to the same CQ would have significantly different max exec time?
There was a problem hiding this comment.
Good question!
For timelimits I could see value in having it in both LQ/CQ.
Other values, like workload priority class or TAS settings, I'm not sure they should be at the CQ level.
Drawing parallels to slurm, it looks like they have time limits at the partition level (I think thats CQ) but you can also set timelimits for users I think.
There was a problem hiding this comment.
I saw you +1 this PR so curious if you have any thoughts on where this config should live.
What type of PR is this?
/kind kep
What this PR does / why we need it:
Adds KEP-7029 proposing the ability to configure a default maximum execution time on a LocalQueue. When a job is submitted to a LocalQueue with a default maximum execution time configured, the resulting workload will automatically have its
maximumExecutionTimeSecondsfield set, unless the job already specifies a value via thekueue.x-k8s.io/max-exec-time-secondslabel.This builds on KEP-3125 (maximum execution time) and addresses community requests in:
Which issue(s) this PR fixes:
Fixes #7029
Special notes for your reviewer:
This is the KEP only. Implementation will follow in a separate PR.
Does this PR introduce a user-facing change?