fix: add deprecated warnings to kind and api fields

[afzal442]

Fix: #5140

[k8s-ci-robot]

Welcome @afzal442!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @afzal442. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[koba1t]

Thanks for your contribution!

I added a few review comment, please check.
Also, is it possible to add a test case to verify that warning messages are output correctly?

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[afzal442]

tide/merge-method-squash

[afzal442]

is it possible to add a test case to verify that warning messages are output correctly?

sorry! I don't think so. could you advise here?

[koba1t]

@afzal442
This is because the existence of tests ensures new features will work correctly in the future and allows us to verify that functionality remains stable even when making subsequent changes.
As a policy, pull requests adding features without corresponding tests will not be merged.
https://github.com/kubernetes-sigs/kustomize/blob/master/CONTRIBUTING.md#reviewer-guide

[stormqueen1990]

Hi there, @afzal442!

Adding on to @koba1t's previous message, we currently have tests for this functionality under api/types/kustomization_test.go:

kustomize/api/types/kustomization_test.go

Lines 19 to 95 in f23d45f

	func TestKustomization_CheckDeprecatedFields(t *testing.T) {
	tests := []struct {
	name string
	k Kustomization
	want *[]string
	}{
	{
	name: "using_bases",
	k: Kustomization{
	Bases: []string{"base"},
	},
	want: &[]string{deprecatedBaseWarningMessage},
	},
	{
	name: "using_CommonLabels",
	k: Kustomization{
	CommonLabels: map[string]string{},
	},
	want: &[]string{deprecatedCommonLabelsWarningMessage},
	},
	{
	name: "using_ImageTags",
	k: Kustomization{
	ImageTags: []Image{},
	},
	want: &[]string{deprecatedImageTagsWarningMessage},
	},
	{
	name: "usingPatchesJson6902",
	k: Kustomization{
	PatchesJson6902: []Patch{},
	},
	want: &[]string{deprecatedPatchesJson6902Message},
	},
	{
	name: "usingPatchesStrategicMerge",
	k: Kustomization{
	PatchesStrategicMerge: []PatchStrategicMerge{},
	},
	want: &[]string{deprecatedPatchesStrategicMergeMessage},
	},
	{
	name: "usingVar",
	k: Kustomization{
	Vars: []Var{},
	},
	want: &[]string{deprecatedVarsMessage},
	},
	{
	name: "usingAll",
	k: Kustomization{
	Bases: []string{"base"},
	CommonLabels: map[string]string{},
	ImageTags: []Image{},
	PatchesJson6902: []Patch{},
	PatchesStrategicMerge: []PatchStrategicMerge{},
	Vars: []Var{},
	},
	want: &[]string{
	deprecatedBaseWarningMessage,
	deprecatedCommonLabelsWarningMessage,
	deprecatedImageTagsWarningMessage,
	deprecatedPatchesJson6902Message,
	deprecatedPatchesStrategicMergeMessage,
	deprecatedVarsMessage,
	},
	},
	}
	for _, tt := range tests {
	t.Run(tt.name, func(t *testing.T) {
	k := tt.k
	if got := k.CheckDeprecatedFields(); !reflect.DeepEqual(got, tt.want) {
	t.Errorf("Kustomization.CheckDeprecatedFields() = %v, want %v", got, tt.want)
	}
	})
	}
	}

[stormqueen1990]

/uncc

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afzal442
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afzal442]

/review @stormqueen1990

[koba1t]

@afzal442

Thanks for adding testcase!
Please add two more tests, one missing only apiVersion and another missing only Kind.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[afzal442]

/remove-lifecycle rotten

[afzal442]

/open

[koba1t]

/reopen

[k8s-ci-robot]

@koba1t: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[afzal442]

@koba1t can we merge this now after the approval?