Unset kubernetes vars for unit tests#3961
Unset kubernetes vars for unit tests#3961dfajmon wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Unit tests fail on cluster when KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT are set.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dfajmon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dfajmon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
What this PR does / why we need it:
Unset Kubernetes vars for unit tests.
Unit tests fail on the cluster when KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT are set. Unit tests shouldn't be affected by these variables even in the testing environment on the cluster.
Testing done:
Unit tests pass.
Special notes for your reviewer:
Release note: