Add Supervisor CSI CreateVolume support for vSAN File Service volumes via FVS by divyenpatel · Pull Request #3972 · kubernetes-sigs/vsphere-csi-driver

divyenpatel · 2026-04-15T20:29:23Z

What this PR does / why we need it:

Add the supervisor CSI path that provisions vSAN file service volumes for PVCs created using storage classes vsan-file-service-policy and vsan-file-service-policy-latebinding through the File Volume Service (FVS) when NSX VPC networking and the supports_vsan_fileservice capability are enabled.

Instance namespace selection

Resolve the consumer supervisor namespace's VPC using the namespace annotation nsx.vmware.com/vpc_network_config → cluster-scoped VPCNetworkConfiguration CR.
Match peer namespaces by status.vpcs[0].name; skip namespaces without the annotation.
Enumerate Namespaces and retain those with matching requested topology zones (namespaceHasAnyRequestedZone). When creating a FileVolume, choose the first such candidate namespace that has a FileVolumeService with status.healthState Ready (instanceNamespaceHasReadyFileVolumeService).

FileVolume lifecycle

Create or reuse a FileVolume CR named by PVC UID in a chosen instance namespace; wait for Ready phase, export path, and endpoint from status.

Volume identity and classification

Return CSI volume IDs as fv:: using common.FVSVolumeIDPrefix.

RBAC for filevolumes, filevolumeservices (fvs.vcf.broadcom.com), and vpcnetworkconfigurations (crd.nsx.vmware.com) in supervisor manifests.

Unit tests for FVS helpers, fake dynamic client list kinds, and gomonkey where needed.

Testing done:
Pre-checkins
https://jenkins-vcf-csifvt.devops.broadcom.net/view/instapp/job/wcp-instapp-e2e-pre-checkin/1252/ - Pass
https://jenkins-vcf-csifvt.devops.broadcom.net/view/instapp/job/vks-instapp-e2e-pre-checkin/1019/ - Failed.
This PR is not related to VKS and only contains supervisor changes.

Verified creating file volume using legacy architecture to ensure no regression happening for CreateVolume workflow.

Unit tests

fixed. Verified running unit tests locally on my mac

% go test -count=1 ./pkg/csi/service/wcp/ \
  -run 'Test(IsVsanFileServicePolicyStorageClass|VPCPathFromVPCNetworkConfiguration|TopologyListFromZoneMap|NamespaceHasAnyRequestedZone|FvsAccessibleTopology|FindVPCNetworkConfigurationForNamespace|GetVPCPathForNamespace|ListFVSCandidateInstanceNamespaces|InstanceNamespaceHasReadyFileVolumeService|CreateFileVolumeViaFVS_ValidationAndPVC|ShouldProvisionVsanFileVolumeViaFVS)$'
ok  	sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp	1.398s
dp024984@MY756TCN94 vsphere-csi-driver % go test -count=1 ./pkg/csi/service/wcp/ \
  -run 'Test(IsVsanFileServicePolicyStorageClass|VPCPathFromVPCNetworkConfiguration|TopologyListFromZoneMap|NamespaceHasAnyRequestedZone|FvsAccessibleTopology|FindVPCNetworkConfigurationForNamespace|GetVPCPathForNamespace|ListFVSCandidateInstanceNamespaces|InstanceNamespaceHasReadyFileVolumeService|CreateFileVolumeViaFVS_ValidationAndPVC|ShouldProvisionVsanFileVolumeViaFVS)$' -v
=== RUN   TestIsVsanFileServicePolicyStorageClass
--- PASS: TestIsVsanFileServicePolicyStorageClass (0.00s)
=== RUN   TestVPCPathFromVPCNetworkConfiguration
--- PASS: TestVPCPathFromVPCNetworkConfiguration (0.00s)
=== RUN   TestTopologyListFromZoneMap
--- PASS: TestTopologyListFromZoneMap (0.00s)
=== RUN   TestFvsAccessibleTopology
--- PASS: TestFvsAccessibleTopology (0.00s)
=== RUN   TestFindVPCNetworkConfigurationForNamespace
--- PASS: TestFindVPCNetworkConfigurationForNamespace (0.23s)
=== RUN   TestGetVPCPathForNamespace
--- PASS: TestGetVPCPathForNamespace (0.20s)
=== RUN   TestListFVSCandidateInstanceNamespaces
{"level":"info","time":"2026-04-21T17:35:07.836147-07:00","caller":"wcp/fvs_filevolume.go:162","msg":"listFVSCandidateInstanceNamespaces: consumer namespace \"pvc-ns\" uses VPC path \"/orgs/default/projects/default/vpcs/same-vpc\", requested zones [zone-a]"}
{"level":"info","time":"2026-04-21T17:35:07.837972-07:00","caller":"wcp/fvs_filevolume.go:193","msg":"listFVSCandidateInstanceNamespaces: namespace \"inst-ns\" matches consumer VPC path \"/orgs/default/projects/default/vpcs/same-vpc\" (VPCNetworkConfiguration \"inst-ns-44444444-4444-4444-4444-444444444444\")"}
{"level":"info","time":"2026-04-21T17:35:07.838003-07:00","caller":"wcp/fvs_filevolume.go:202","msg":"listFVSCandidateInstanceNamespaces: adding namespace \"inst-ns\" to FVS candidate list (VPC path \"/orgs/default/projects/default/vpcs/same-vpc\", requested zones [zone-a])"}
--- PASS: TestListFVSCandidateInstanceNamespaces (0.10s)
=== RUN   TestInstanceNamespaceHasReadyFileVolumeService
--- PASS: TestInstanceNamespaceHasReadyFileVolumeService (0.00s)
=== RUN   TestCreateFileVolumeViaFVS_ValidationAndPVC
=== RUN   TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_PVC_parameters
{"level":"error","time":"2026-04-21T17:35:07.838632-07:00","caller":"wcp/fvs_filevolume.go:300","msg":"missing PVC name or namespace in CreateVolume parameters","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:300\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func1\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:356\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"}
=== RUN   TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_accessibility_requirements
{"level":"error","time":"2026-04-21T17:35:07.83877-07:00","caller":"wcp/fvs_filevolume.go:305","msg":"accessibility requirements are required for FVS file volume provisioning","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:305\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func2\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:368\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"}
=== RUN   TestCreateFileVolumeViaFVS_ValidationAndPVC/volume_name_without_extractable_PVC_UID
{"level":"error","time":"2026-04-21T17:35:07.838911-07:00","caller":"common/util.go:482","msg":"failed to extract UID from volumeName name: \"invalid-volume-name\"","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/common.ExtractVolumeIDFromPVName\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/common/util.go:482\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:309\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func3\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:384\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"}
{"level":"error","time":"2026-04-21T17:35:07.838982-07:00","caller":"wcp/fvs_filevolume.go:311","msg":"failed to extract PVC UID from volume name \"invalid-volume-name\": failed to extract UID from volumeName name: \"invalid-volume-name\"","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:311\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func3\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:384\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"}
--- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC (0.00s)
    --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_PVC_parameters (0.00s)
    --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_accessibility_requirements (0.00s)
    --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC/volume_name_without_extractable_PVC_UID (0.00s)
=== RUN   TestShouldProvisionVsanFileVolumeViaFVS
=== RUN   TestShouldProvisionVsanFileVolumeViaFVS/non-VPC_network_provider_returns_FailedPrecondition
=== RUN   TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_disabled
=== RUN   TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_enabled
--- PASS: TestShouldProvisionVsanFileVolumeViaFVS (0.00s)
    --- PASS: TestShouldProvisionVsanFileVolumeViaFVS/non-VPC_network_provider_returns_FailedPrecondition (0.00s)
    --- PASS: TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_disabled (0.00s)
    --- PASS: TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_enabled (0.00s)
PASS
ok  	sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp	1.151s

Special notes for your reviewer:

Release note:

Add Supervisor CSI CreateVolume support for vSAN File Service volumes via FVS

deepakkinni · 2026-04-20T20:32:20Z

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1017

deepakkinni · 2026-04-20T20:32:22Z

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1250

deepakkinni · 2026-04-20T21:05:15Z

FAILED --- Jenkins Build #1250

deepakkinni · 2026-04-20T22:46:45Z

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1252

deepakkinni · 2026-04-20T22:48:57Z

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1019

deepakkinni · 2026-04-20T23:07:45Z

FAILED --- Jenkins Build #1019

deepakkinni · 2026-04-20T23:45:17Z

SUCCESS --- Jenkins Build #1252

deepakkinni · 2026-04-21T03:29:44Z

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1020

deepakkinni · 2026-04-21T04:11:37Z

SUCCESS --- Jenkins Build #1020

deepakkinni · 2026-04-21T05:56:25Z

+	// Phase 2: no existing FileVolume — pick one candidate namespace and create the CR.
+	if instanceNS == "" {
+		var targetNS string
+		for _, ns := range candidateNamespaces {


Would it be possible/reasonable to randomize candidateNamespaces each time? In the current approach one of the namespace could become a hotspot;

done. added random logic.

// Randomize order so repeated creates do not always probe the same instance namespace first (hotspot). rand.Shuffle(len(candidateNamespaces), func(i, j int) { candidateNamespaces[i], candidateNamespaces[j] = candidateNamespaces[j], candidateNamespaces[i] })

deepakkinni · 2026-04-21T05:57:06Z

+			Spec: fvv1alpha1.FileVolumeSpec{
+				PvcUID:    pvcUID,
+				Size:      *qty,
+				Protocols: []fvv1alpha1.FileVolumeProtocol{fvv1alpha1.FileVolumeProtocolNFSv4},


Is it always v4 protocol? do mount command change if its v4?

we will always use nfs v4 protocol.
Devops does not have the option to request file volume with specific network protocol - nfs3, nfs4 etc.

deepakkinni · 2026-04-21T05:59:10Z

+	err = wait.PollUntilContextTimeout(ctx, fvsWaitStep, fvsWaitMax, true, func(ctx context.Context) (bool, error) {
+		if err := c.fileVolumeClient.Get(ctx, ctrlclient.ObjectKey{Namespace: instanceNS, Name: fvName}, fv); err != nil {
+			return false, err
+		}
+		phase := fv.Status.Phase
+		if phase == "" {
+			return false, nil
+		}
+		if strings.EqualFold(string(phase), string(fvv1alpha1.FileVolumePhaseError)) {
+			return false, fmt.Errorf("FileVolume %s/%s entered Error phase", instanceNS, fvName)
+		}
+		if !strings.EqualFold(string(phase), string(fvv1alpha1.FileVolumePhaseReady)) {
+			return false, nil
+		}
+		exportPath = fv.Status.ExportPath
+		endpoint = fv.Status.Endpoint
+		return exportPath != "" && endpoint != "", nil
+	})


I was thinking about this, won't this be mostly static? why not cache this?

Btw, vcfa support 1.5k namesapce, and it could keep increasing.

added namespace informer cache

deepakkinni · 2026-04-21T06:02:08Z

+const (
+	fvsGroup    = "fvs.vcf.broadcom.com"
+	fvsVersion  = "v1alpha1"
+	fvsWaitStep = 5 * time.Second


why are the waits needed? add in comment

deepakkinni · 2026-04-21T06:07:20Z

+				"no instance namespace with a healthy FileVolumeService for requested zones %v", requestedZones)
+		}
+
+		fvTyped := &fvv1alpha1.FileVolume{


Lets log this

done printed

log.Infof("Creating FileVolume CR for PVC %s/%s: %+v", pvcNamespace, pvcName, fvTyped)

deepakkinni · 2026-04-21T06:09:26Z

+
+	fv := &fvv1alpha1.FileVolume{}
+	var exportPath, endpoint string
+	err = wait.PollUntilContextTimeout(ctx, fvsWaitStep, fvsWaitMax, true, func(ctx context.Context) (bool, error) {


Can we add some profiling here? we can know how long these creation takes

We already have metric to measure time it take to create file volume. For now just to align with csi-provisioner sidecar timeout for createvolume, we have set max wait timeout to 5 minutes.

prometheus.CsiControlOpsHistVec.WithLabelValues(volumeType, prometheus.PrometheusCreateVolumeOpType, prometheus.PrometheusPassStatus, faultType).Observe(time.Since(start).Seconds())

xing-yang · 2026-04-21T20:28:42Z

+
+	candidateNamespaces, err := c.listFVSCandidateInstanceNamespaces(ctx, pvcNamespace, requestedZones)
+	if err != nil {
+		return nil, csifault.CSIInternalFault, logger.LogNewErrorCodef(log, codes.FailedPrecondition,


What does FailedPrecondition mean here? This error code is not documented in CSI spec for CreateVolume. Maybe INVALID_ARGUMENT is more appropriate. It means "Source incompatible or not supported".

FailedPrecondition is defined here
https://github.com/grpc/grpc/blob/master/doc/statuscodes.md

FailedPrecondition: The operation was rejected because the system is not in a state required for the operation's execution.

We have used this code at other places in CSI.

Since User provided PVC spec is valid and internal state of the system is not Ready (candidate namespaces not available to provision filevolume CR), returning FailedPrecondition here.

xing-yang · 2026-04-21T20:29:32Z

+			break
+		}
+		if targetNS == "" {
+			return nil, csifault.CSIInternalFault, logger.LogNewErrorCodef(log, codes.FailedPrecondition,


Same as above.

xing-yang · 2026-04-21T20:34:29Z

+	return ""
+}
+
+// findVPCNetworkConfigurationForNamespace loads the supervisor Namespace, reads the


Can you add a note to follow up to see if it is possible not to go through all the namespaces?

added TODO

// TODO: FileVolumeService: filter namespaces by labels for instance namespaces nsObjs, err := c.namespaceLister.List(labels.Everything())

label for instance namespace is finalized.
added namespace filtering with label fvs_instance_namespace = true in 5721ee7

xing-yang · 2026-04-21T20:37:20Z

+}
+
+func TestNamespaceHasAnyRequestedZone_Intersection(t *testing.T) {
+	patches := gomonkey.ApplyMethod(reflect.TypeOf(&unittestcommon.FakeK8SOrchestrator{}), "GetZonesForNamespace",


This still uses gomonkey. There is a PR #3980 that replaces gomonkey with injectable clients. See if these can be replaced. This comment is non-blocking.

fixed. Verified running unit tests locally on my mac

% go test -count=1 ./pkg/csi/service/wcp/ \ -run 'Test(IsVsanFileServicePolicyStorageClass|VPCPathFromVPCNetworkConfiguration|TopologyListFromZoneMap|NamespaceHasAnyRequestedZone|FvsAccessibleTopology|FindVPCNetworkConfigurationForNamespace|GetVPCPathForNamespace|ListFVSCandidateInstanceNamespaces|InstanceNamespaceHasReadyFileVolumeService|CreateFileVolumeViaFVS_ValidationAndPVC|ShouldProvisionVsanFileVolumeViaFVS)$' ok sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp 1.398s dp024984@MY756TCN94 vsphere-csi-driver % go test -count=1 ./pkg/csi/service/wcp/ \ -run 'Test(IsVsanFileServicePolicyStorageClass|VPCPathFromVPCNetworkConfiguration|TopologyListFromZoneMap|NamespaceHasAnyRequestedZone|FvsAccessibleTopology|FindVPCNetworkConfigurationForNamespace|GetVPCPathForNamespace|ListFVSCandidateInstanceNamespaces|InstanceNamespaceHasReadyFileVolumeService|CreateFileVolumeViaFVS_ValidationAndPVC|ShouldProvisionVsanFileVolumeViaFVS)$' -v === RUN TestIsVsanFileServicePolicyStorageClass --- PASS: TestIsVsanFileServicePolicyStorageClass (0.00s) === RUN TestVPCPathFromVPCNetworkConfiguration --- PASS: TestVPCPathFromVPCNetworkConfiguration (0.00s) === RUN TestTopologyListFromZoneMap --- PASS: TestTopologyListFromZoneMap (0.00s) === RUN TestFvsAccessibleTopology --- PASS: TestFvsAccessibleTopology (0.00s) === RUN TestFindVPCNetworkConfigurationForNamespace --- PASS: TestFindVPCNetworkConfigurationForNamespace (0.23s) === RUN TestGetVPCPathForNamespace --- PASS: TestGetVPCPathForNamespace (0.20s) === RUN TestListFVSCandidateInstanceNamespaces {"level":"info","time":"2026-04-21T17:35:07.836147-07:00","caller":"wcp/fvs_filevolume.go:162","msg":"listFVSCandidateInstanceNamespaces: consumer namespace \"pvc-ns\" uses VPC path \"/orgs/default/projects/default/vpcs/same-vpc\", requested zones [zone-a]"} {"level":"info","time":"2026-04-21T17:35:07.837972-07:00","caller":"wcp/fvs_filevolume.go:193","msg":"listFVSCandidateInstanceNamespaces: namespace \"inst-ns\" matches consumer VPC path \"/orgs/default/projects/default/vpcs/same-vpc\" (VPCNetworkConfiguration \"inst-ns-44444444-4444-4444-4444-444444444444\")"} {"level":"info","time":"2026-04-21T17:35:07.838003-07:00","caller":"wcp/fvs_filevolume.go:202","msg":"listFVSCandidateInstanceNamespaces: adding namespace \"inst-ns\" to FVS candidate list (VPC path \"/orgs/default/projects/default/vpcs/same-vpc\", requested zones [zone-a])"} --- PASS: TestListFVSCandidateInstanceNamespaces (0.10s) === RUN TestInstanceNamespaceHasReadyFileVolumeService --- PASS: TestInstanceNamespaceHasReadyFileVolumeService (0.00s) === RUN TestCreateFileVolumeViaFVS_ValidationAndPVC === RUN TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_PVC_parameters {"level":"error","time":"2026-04-21T17:35:07.838632-07:00","caller":"wcp/fvs_filevolume.go:300","msg":"missing PVC name or namespace in CreateVolume parameters","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:300\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func1\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:356\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"} === RUN TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_accessibility_requirements {"level":"error","time":"2026-04-21T17:35:07.83877-07:00","caller":"wcp/fvs_filevolume.go:305","msg":"accessibility requirements are required for FVS file volume provisioning","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:305\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func2\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:368\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"} === RUN TestCreateFileVolumeViaFVS_ValidationAndPVC/volume_name_without_extractable_PVC_UID {"level":"error","time":"2026-04-21T17:35:07.838911-07:00","caller":"common/util.go:482","msg":"failed to extract UID from volumeName name: \"invalid-volume-name\"","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/common.ExtractVolumeIDFromPVName\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/common/util.go:482\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:309\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func3\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:384\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"} {"level":"error","time":"2026-04-21T17:35:07.838982-07:00","caller":"wcp/fvs_filevolume.go:311","msg":"failed to extract PVC UID from volume name \"invalid-volume-name\": failed to extract UID from volumeName name: \"invalid-volume-name\"","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.(*controller).createFileVolumeViaFVS\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume.go:311\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp.TestCreateFileVolumeViaFVS_ValidationAndPVC.func3\n\t/Users/dp024984/go/src/github.com/vsphere-csi-driver/pkg/csi/service/wcp/fvs_filevolume_test.go:384\ntesting.tRunner\n\t/Users/dp024984/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.2.darwin-arm64/src/testing/testing.go:2036"} --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC (0.00s) --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_PVC_parameters (0.00s) --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC/missing_accessibility_requirements (0.00s) --- PASS: TestCreateFileVolumeViaFVS_ValidationAndPVC/volume_name_without_extractable_PVC_UID (0.00s) === RUN TestShouldProvisionVsanFileVolumeViaFVS === RUN TestShouldProvisionVsanFileVolumeViaFVS/non-VPC_network_provider_returns_FailedPrecondition === RUN TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_disabled === RUN TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_enabled --- PASS: TestShouldProvisionVsanFileVolumeViaFVS (0.00s) --- PASS: TestShouldProvisionVsanFileVolumeViaFVS/non-VPC_network_provider_returns_FailedPrecondition (0.00s) --- PASS: TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_disabled (0.00s) --- PASS: TestShouldProvisionVsanFileVolumeViaFVS/VPC_provider_FSS_enabled (0.00s) PASS ok sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcp 1.151s

… (storage classes vsan-file-service-policy and vsan-file-service-policy-latebinding) through the File Volume Service (FVS) when NSX VPC networking and the supports_vsan_fileservice capability are enabled. Instance namespace selection - Resolve the consumer supervisor namespace's VPC using the namespace annotation nsx.vmware.com/vpc_network_config → cluster-scoped VPCNetworkConfiguration CR. - Match peer namespaces by status.vpcs[0].name; skip namespaces without the annotation. - Enumerate Namespaces and retain those with matching requested topology zones (namespaceHasAnyRequestedZone). When creating a FileVolume, choose the first such candidate namespace that has a FileVolumeService with status.healthState Ready (instanceNamespaceHasReadyFileVolumeService). FileVolume lifecycle - Create or reuse a FileVolume CR named by PVC UID in a chosen instance namespace; wait for Ready phase, export path, and endpoint from status. Volume identity and classification - Return CSI volume IDs as fv:<instance-namespace>:<filevolume-name> using common.FVSVolumeIDPrefix. RBAC for filevolumes, filevolumeservices (fvs.vcf.broadcom.com), and vpcnetworkconfigurations (crd.nsx.vmware.com) in supervisor manifests. Unit tests for FVS helpers, fake dynamic client list kinds, and gomonkey where needed.

xing-yang · 2026-04-22T20:47:25Z

/approve

k8s-ci-robot · 2026-04-22T20:47:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [divyenpatel,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2026

k8s-ci-robot requested review from chethanv28 and gnufied April 15, 2026 20:29

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2026

divyenpatel force-pushed the create-volume-with-new-filevolumeservice branch from b0c1488 to 541c876 Compare April 15, 2026 20:40

divyenpatel requested a review from deepakkinni April 15, 2026 20:41

divyenpatel force-pushed the create-volume-with-new-filevolumeservice branch 5 times, most recently from 9266949 to bd0d8b0 Compare April 20, 2026 18:20

divyenpatel commented Apr 20, 2026

View reviewed changes

Comment thread pkg/csi/service/common/constants.go

Comment thread pkg/csi/service/wcp/fvs_filevolume.go Outdated

Comment thread pkg/csi/service/wcp/fvs_filevolume.go Outdated

Comment thread pkg/csi/service/wcp/fvs_filevolume.go Outdated

divyenpatel force-pushed the create-volume-with-new-filevolumeservice branch from bd0d8b0 to 71161bd Compare April 20, 2026 22:32

deepakkinni reviewed Apr 21, 2026

View reviewed changes

xing-yang reviewed Apr 21, 2026

View reviewed changes

divyenpatel force-pushed the create-volume-with-new-filevolumeservice branch from 71161bd to 355836b Compare April 22, 2026 00:36

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 22, 2026

divyenpatel force-pushed the create-volume-with-new-filevolumeservice branch from 355836b to a840175 Compare April 22, 2026 00:45

filter instance namespace for file volume with label

5721ee7

Conversation

divyenpatel commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

deepakkinni commented Apr 20, 2026

Uh oh!

deepakkinni commented Apr 21, 2026

Uh oh!

deepakkinni commented Apr 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xing-yang commented Apr 22, 2026

Uh oh!

k8s-ci-robot commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

divyenpatel commented Apr 15, 2026 •

edited

Loading