Support per-namespace network providers for CnsFileAccessConfig#3976
Open
divyenpatel wants to merge 1 commit intokubernetes-sigs:masterfrom
Open
Support per-namespace network providers for CnsFileAccessConfig#3976divyenpatel wants to merge 1 commit intokubernetes-sigs:masterfrom
divyenpatel wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Resolve network provider and external VM IP from the namespace's NetworkSettings CR when WCP capability supports_per_namespace_network_providers is enabled; otherwise keep reading wcp-network-config via GetNetworkProvider. - List NetworkSettings in the namespace and require exactly one object; map status.provider (vsphere-distributed / nsx-tier1 / vpc) to existing VDS / NSX-T / VPC IP logic. - When per-namespace mode is on, use SNAT when present else fall back to VM primary IP (NSX-T and VPC); legacy behavior unchanged when the capability is off. - Register the capability in WCP feature maps and SupportsLateEnablement; start HandleLateEnablementOfCapability from metadatasyncer so the syncer restarts when the capability is enabled later. - Add/adjust unit tests (fake dynamic client with NetworkSettingsList).
divyenpatel
force-pushed
the
support-per-namespace-network-provider
branch
from
6e98bf3 to
34fa747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Resolve network provider and external VM IP from the namespace's NetworkSettings CR when WCP capability supports_per_namespace_network_providers is enabled; otherwise keep reading wcp-network-config via GetNetworkProvider.
Testing done:
In Progress
Special notes for your reviewer:
Release note: