Improve target naming#763
Open
jhkrug wants to merge 2 commits into
Open
Conversation
… Netlify. Better naming for targets in the Makefile. Use only 1 build directory. Signed-off-by: John Krug <john.krug@suse.com>
Signed-off-by: John Krug <john.krug@suse.com>
github-project-automation
Bot
moved this to Pending review
in Kubewarden Admission Controller
✅ Deploy Preview for docs-kubewarden-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the docs build configuration to consolidate Antora playbooks/output directories and improve Makefile target naming, aligning Netlify preview builds with a CLI-defined Antora attribute.
Changes:
- Switched Netlify to build via a renamed Makefile target (
community-netlify-preview). - Consolidated Antora output to a single directory (
build/site) and removed the dedicated Netlify playbook. - Simplified/renamed local preview target (
preview) and streamlined build logging.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| netlify.toml | Uses the new Makefile target for Netlify preview builds. |
| Makefile | Renames/adjusts build + preview targets, unifies output dir and log naming, and adds CLI attribute for Netlify builds. |
| kw-remote-community-playbook.yml | Removes commented URL configuration block (no functional change). |
| kw-remote-community-netlify-playbook.yml | Deleted; Netlify-specific behavior moved to CLI attribute on the Makefile target. |
| kw-local-community-playbook.yml | Changes output directory to build/site to match other build flows. |
Comments suppressed due to low confidence (1)
Makefile:39
ln -s kubewarden/latest latesthas the same non-idempotent behavior in the Netlify preview target; a second run without cleaning will fail ifbuild/site/latestalready exists. Use an idempotent symlink creation approach so Netlify rebuilds (or local reruns) don't fail unexpectedly.
cd build/site && ln -s kubewarden/latest latest
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jvanz
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce to 2 playbooks by using a command line attribute definition for Netlify. Better naming for targets in the Makefile. Use only 1 build directory.
Signed-off-by: John Krug john.krug@suse.com