Repository navigation
Lead with JSX in HTML in the site, npm and README metadata - #4
Merged
Merged
Conversation
Site: title, description, Open Graph and Twitter tags now describe the JSX in plain HTML feature, with a 1200x630 share image and SoftwareSourceCode JSON-LD. The hreflang alternates and the ?lang sitemap entries are removed: they pointed at client side translations of the same document, and the sitemap and the page disagreed on which language the root URL was. npm: the description and keywords lead with JSX, and the unpkg and jsdelivr fields serve voodoo.full.min.js, since the smaller builds do not include the JSX reader and the bare CDN URL showed the README example as plain text. README: say that JSX needs the full build, and add a JSX column to the bundle table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Site (
site/index.html,site/sitemap.xml).htmlfile with no build step. The previous copy described an attribute based framework, which is how Alpine, htmx and petite-vue already describe themselves.site/assets/og.png) withog:imageandtwitter:card, so links shared on X, LinkedIn, Slack or Discord show a preview instead of a bare URL.SoftwareSourceCodeJSON-LD.hreflangalternates and the?lang=sitemap entries. They point at client side translations of the same HTML, so search engines see one document, and the page and the sitemap disagreed about the root language (enin the page,pt-BRin the sitemap).npm (
packages/voodoojs/package.json)jsxwas not a keyword).unpkgandjsdelivrnow point atvoodoo.full.min.js. The smaller builds do not include the JSX reader, sohttps://cdn.jsdelivr.net/npm/voodoojsrendered the README example as plain text with no warning. Takes effect on the next publish.README (EN and pt-BR)
GitHub social preview
brand/social/github-social-preview.png(1280x640) is ready to upload in Settings, Social preview.Checks
node scripts/check-packaging.mjs,node scripts/check-docs-language.mjs --checkandnode scripts/check-links.mjspass.voodoo.full.min.jsfrom jsDelivr.