Move PhD auxiliary-file generation out to php/phd - #1
Closed
lacatoire wants to merge 1 commit into
Closed
Conversation
configure.php now only assembles and validates the XML. The generation of version.xml, sources.xml and fileModHistory.php is removed (phd_acronym, php_history, phd_sources, phd_version) and delegated to php/phd via a doc-base/temp/phd-conf.json handoff. Also fixes the --history-file option, which set SOURCES_FILE instead of HISTORY_FILE. Depends on php/phd (adds genphdfiles.php). The build pipeline must call 'php phd/genphdfiles.php doc-base/temp/phd-conf.json' before this lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging PR (fork-internal review before targeting php/doc-base).
configure.php now only assembles and validates XML. Removes the generation of version.xml, sources.xml and fileModHistory.php (phd_acronym/php_history/phd_sources/phd_version), delegating it to php/phd via doc-base/temp/phd-conf.json. Also fixes --history-file, which set SOURCES_FILE instead of HISTORY_FILE.
Companion: lacatoire/phd#2 (adds genphdfiles.php). Do NOT merge before the pipeline calls:
php phd/genphdfiles.php doc-base/temp/phd-conf.json
Verified end-to-end with the phd PR: the three files are byte-identical to master (docker php:8.4-cli, en).